-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Don't run NPM Test in Windows #3302
Conversation
57dd5f6
to
618ee1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to use continue-on-error
here instead.
That way, the job continues to run and provides feedback so we can track any changes to this behavior over time as debugging continues.
Good point, thank you! I'll apply your suggestions 👍 |
Co-authored-by: Jon Desrosiers <[email protected]>
Co-authored-by: Jon Desrosiers <[email protected]>
Disable the NPM Test CI workflow in Windows. This is a workaround for this issue so it doesn't get in the way of WP 6.1 Beta 1.
The issue is being actively investigated here.
Trac ticket:
cc/ @Clorith @t-hamano @desrosj @gziolo @jsnajdr @c4rl0sbr4v0
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.