Templates API: return post modified datetime in response #4613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/wp-includes/rest-api/endpoints/class-wp-rest-templates-controller.php
Outdated
Show resolved
Hide resolved
…troller.php Co-authored-by: Andrew Serong <[email protected]>
…even for file-based templates.
| @@ -926,6 +935,13 @@ public function get_item_schema() { | |||
| 'type' => 'integer', | |||
| 'context' => array( 'view', 'edit', 'embed' ), | |||
| ), | |||
| 'modified' => array( | |||
| 'description' => __( "The date the template was last modified, in the site's timezone." ), | |||
There was a problem hiding this comment.
Suggested change
| 'description' => __( "The date the template was last modified, in the site's timezone." ), | |
| 'description' => __( 'The date the template was last modified, in the site's timezone.' ), |
There was a problem hiding this comment.
The double quote are there because of the single quotes in site's. I can update the language to avoid the apostrophe if you think it's better.
I copied it from WP_REST_Posts_Controller
There was a problem hiding this comment.
Ohh leave it then or you can update like below.
__( 'The date the template was last modified, in the site\'s timezone.' )
src/wp-includes/rest-api/endpoints/class-wp-rest-templates-controller.php
Outdated
Show resolved
Hide resolved
ramonjd
changed the title
ramonjd
added a commit
to ramonjd/wordpress-develop
that referenced
this pull request
Jun 23, 2023
…lt_from_post The wrong object was used in the template part assertion. This commit corrects that.
|
Sorry @tellthemachines and @TimothyBJacobs I just realized I added a breaking change to PHP unit tests on this line: It'll cause the tests to fail sometimes (when they don't run fast enough 😄 ) Fix here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding 'modified' field and value (if available) to template rest APIcontroller
Synching Core with:
Trac ticket: https://core.trac.wordpress.org/ticket/58540
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.