-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump the minimum required version of Node.js to 20.x #5515
Conversation
…into update/nodejs-20 # Conflicts: # src/wp-content/themes/twentytwentyone/assets/css/ie-editor.css.map # src/wp-content/themes/twentytwentyone/assets/css/ie.css.map
Also test sending no `node` input.
I've made a request to the systems team to install 20.x on the build server. It's possible we can skip 18.x all together, though I'd advise we proceed as though we'll only have 18.x available for this current cycle (WP 6.5). We can always bump a second time should something change. |
@swissspidy It seems that this change will cause the comparison between the previous branch and this one to fail because of the differing versions of Node.js/npm between them. Any idea around the best way to resolve this? I do plan to backport this update to the 6.4 branch because that is currently the only other one that uses Will that then cause the workflow to fail in the 6.4 branch when comparing the 6.3 branch? I'd expect it to be failing currently since the 6.3 branch uses 14.x and not 16.x. 🤔 |
@desrosj I think the old ones aren't failing because this will only happen when the workflow is run when comparing the current commit to the previous commit when the previous commit uses a different node version. Perhaps adding an |
What Joe says :) |
Trac ticket: https://core.trac.wordpress.org/ticket/59663
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.