mirrored from git://develop.git.wordpress.org/
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove building wp_template_parts variation call for frontend #5718
Closed
Closed
Changes from 5 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
7a95c4f
remove varation
kt-12 70fb7aa
introduce get all variation
kt-12 a41c600
cs fixes
kt-12 04de489
cs fixes
kt-12 9146a55
filter to callback
kt-12 d495db0
Add Variation to block-types rest api
kt-12 3f8b154
navigation link and post term to block varation to callback
kt-12 d382bb9
Update src/wp-includes/class-wp-block-type.php
kt-12 26baa27
Merge branch 'enhancement/remove-variation-fontend' of https://github…
kt-12 cc598f2
doc block
kt-12 c174980
dock block
kt-12 8ad9728
phpcs fixes
kt-12 d9dabaa
Merge branch 'trunk' of https://github.com/WordPress/wordpress-develo…
kt-12 e8ebb6f
Update src/wp-includes/class-wp-block-type.php
kt-12 9d5812d
Making name consistant
kt-12 6a4433d
Merge branch 'enhancement/remove-variation-fontend' of https://github…
kt-12 5c3ad2c
callback support with backward compatibility
kt-12 b1d3664
Allow setting of value. Doc block for variation callback
kt-12 9c475a9
variations set to null initially
kt-12 3cb7d40
isset logic
kt-12 0351ae6
test cases for variation callback
kt-12 5480c0f
remove isset as variations will never be returned as null.
kt-12 a68e5e0
isset always true for variations
kt-12 cd38417
revert back navigation-link to
kt-12 b604464
revert back to trunk
kt-12 93e4457
Merge branch 'trunk' into enhancement/remove-variation-fontend
kt-12 39ee3ee
set to null
kt-12 34bcc84
test cases for multiple cases
kt-12 94aa0fe
additional test cases
kt-12 bae4e71
change message
kt-12 2918539
cs fixes
kt-12 686c243
Update tests/phpunit/tests/blocks/wpBlockType.php
kt-12 689d48c
Update tests/phpunit/tests/blocks/wpBlockType.php
kt-12 aafceda
Move filter function one up
kt-12 b0730c7
remove filters and expand doc block defnetion
kt-12 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's okay to have these changes here for now and remove them before merging into the core. Then, we can update the code in the
block-library
package in a backward compatible way. The Gutenberg plugin supports multiple WP versions.