-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default value of settings.shadow.defaultPresets to false #6255
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I apologize for the oversight in the initial pull request. I've reviewed the changes, and they look good to me. Thank you for taking care of this.
What are the testing instructions for this? |
The testing instructions should be something like:
|
Thanks @youknowriad, I can confirm this then 👍 |
Thank you. This is correct. |
Committed to trunk in https://core.trac.wordpress.org/changeset/57827 Needs double sign-off ( |
Added the "dev-reviewed" tag. This LGTM |
This PR is a follow-up to #6178.
The original Gutenberg PR had a change made to
theme.json
, but #6178 did not include it.Trac ticket: https://core.trac.wordpress.org/ticket/60633
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.