Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression with theme.json settings.shadow.defaultPresets (minimal) #6303

Conversation

ajlende
Copy link

@ajlende ajlende commented Mar 21, 2024

All discussion for this issue should be done in WordPress/gutenberg#59989

Alternative to #6295 without the editor-shadow-presets theme support feature.

  • Reverts core theme.json settings.shadow.defaultPresets to true to fix the regression. (Back to working the same as color/gradient preset configuration for block themes.)

The color/gradient support behavior that I think we should be matching enables support for the presets in classic themes by default and allows themes to opt-out. For example, gradients can be opted-out of by setting add_theme_support( 'editor-gradient-presets', array() ).

If we're okay with shadows being opt-out in the UI like colors/gradients, we can merge just this and add the ability to opt-out with add_theme_support( 'editor-shadow-presets', array() ) that's included in #6295 as a follow-up in 6.6.

Trac ticket: https://core.trac.wordpress.org/ticket/60815


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props ajlende.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@swissspidy
Copy link
Member

Looks like we're converging towards focusing on #6309, so closing this one.

@swissspidy swissspidy closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants