Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load fonts from style variations in the editor and the admin #7581

Conversation

matiasbenedetto
Copy link

@matiasbenedetto matiasbenedetto commented Oct 17, 2024

What:

Load fonts from style variations only in the editor and admin, not in the public frontend.

This is an alternative and probably simpler alternative to the Gutenberg PR: WordPress/gutenberg#65019 and it core port PR: #7570

Trac ticket: https://core.trac.wordpress.org/ticket/62231

Testing Instructions:

Try to load a style variation and check that the fonts referenced in those style variations load as expected.

I created a theme to test this quickly and visually:
font-variants.zip
In this theme, the alternative font families and font faces with theme-relative URLs are defined in the style variations.

Sceencast

2024-10-17.11-10-40.mp4

Copy link

github-actions bot commented Oct 17, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props mmaattiiaass, peterwilsoncc, ironprogrammer.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@getdave getdave requested a review from peterwilsoncc October 18, 2024 14:03
Copy link

@ironprogrammer ironprogrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @matiasbenedetto! I've left some feedback on improving a unit test.

Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and tests well.

I took the liberty of pushing some changes to the tests to allow for commit:

@peterwilsoncc
Copy link
Contributor

Merged r59260 / ba47208

Thanks Matias.

justintadlock added a commit to x3p0-dev/x3p0-ideas that referenced this pull request Oct 21, 2024
This seems to mostly work in WordPress 6.7 now: WordPress/wordpress-develop#7581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants