-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a job for running the HTML API tests. #7602
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
@sirreal @aaronjorbin What do you think about this approach? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. I really want to get these tests running, thank you.
I've left notes and questions but nothing blocking.
.github/workflows/phpunit-tests.yml
Outdated
memcached: ${{ matrix.memcached }} | ||
phpunit-config: ${{ matrix.multisite && 'tests/phpunit/multisite.xml' || 'phpunit.xml.dist' }} | ||
phpunit-test-groups: ${{ matrix.phpunit-test-groups }} | ||
report: ${{ matrix.report || false }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not report? I believe this flag is for this:
Submit test results to the WordPress.org host test results
I don't know what that implies or means exactly, but these tests should really have the same weight as any other phpunit tests. They should not fail on anything merged for release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tells the workflow to submit the results of running the test suite to the w.org hosting tests.
Currently, the hosting tests does support submitting multiple reports per commit, but it does not support submitting subsets of tests. The assumption is that you run the full test suite, there would be no indication that a report only represents a small segment.
I think, if we wanted to include the results of these tests when submitting, the reusable workflow would need to be updated to somehow include the provided test group and not only group excluding the standard phpunit.xml
setup. This could still run on just one job, but it would then again become nested under the PHP version where it was included.
Let's start without including it in a report and we can always look to include it in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Sure, that sounds good. Just getting these tests running on CIis a big benefit.
Is there anything I can do to help this land? I think #6963 can be closed with this work superseding it. |
@sirreal I think this is good to go! Do you mind giving it a final look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you. The hierarchy of the tests here makes much more sense to me where the specific groups are top-level.
Thanks all! Merged in https://core.trac.wordpress.org/changeset/59528. |
Alternative approach to #6963.
Trac ticket: https://core.trac.wordpress.org/ticket/61209
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.