-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest News block: Add support for cards style and popular categories #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwoodnz
force-pushed
the
enhance/448-latest-news-cards-style
branch
2 times, most recently
from
October 25, 2023 01:29
3d058e4
to
648f338
Compare
Looks good!
Let me know your thoughts. |
Correct!
I'll experiment with no-wrap and column size, I think the full text is probably fine unless we like the shorter format.
👍 Works for me |
adamwoodnz
force-pushed
the
enhance/448-latest-news-cards-style
branch
from
October 25, 2023 23:16
3629c42
to
40a27cf
Compare
adamwoodnz
force-pushed
the
enhance/448-latest-news-cards-style
branch
from
October 26, 2023 02:22
40a27cf
to
178d802
Compare
Merging this, but we can further refine the responsive behaviour if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #448
Adds a Cards style variation and 'showCategories' attribute to the block to support the design for Developer.
Screenshots
Editor
Frontend
Developer
Testing