Port WebAuthn registration to MadWizard library #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will give us a starting point for our version of the provider. The files were copied verbatim, and then minor changes were made to adjust file paths etc and get it working in this plugin. Future commits will swap in the MadWizard library, and make other changes to fit w.org needs. Co-Authored-By: mcguffin <[email protected]>
Without it, tests will fail incorrectly in local environments.
otherwise get `Uncaught Error: Class "Two_Factor_Provider" not found in wp-content/plugins/wporg-two-factor/providers/webauthn/class-two-factor-webauthn.php:11`
only allow patch updates because the API isn't stable until v1.0
this didn't work b/c the ui doesn't match. need to keep the mcguffin code related to UI, but swap in the sjinks code related to credentials
This was referenced May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #114
Builds on #134, which needs to be merged first
This is currently a WIP, but will be the first step in the process of switching to the MadWizard WebAuthn library. It will port the process of registering a new key. A future PR will port the process of logging in with tne registered key.