WebAuthN: Disable EdDSA/Ed25519 for key registrations #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iandunn
approved these changes
May 19, 2023
|
For reference, I tested the following scenarios and all of them worked:
The desktop was a 2023 Mac Mini running OSX |
|
I was thinking of merging #169 first and then applying this in the same manner, rather than having it in multiple places. |
dd32
force-pushed
the
fix/webauthn-upstream-221
branch
from
c59df0a
to
c85f865
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #153
Patch for the upstream sjinks/wp-two-factor-provider-webauthn#221 bug
See #114
The upstream plugin supports a multitude of algorithms, unfortunately it appears that when a modern security key is registered through a desktop browser, EdDSA is preferred, however it appears that at least some Android devices do not support this through NFC.
This PR disables the EdDSA algorithm during key registration.