Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEDX-534 : Migrate contextual_message to GHA #17

Merged
merged 37 commits into from
Nov 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
6a30f03
FEDX-534 : Migrate contextual_message to GHA
alishadalal-wk Nov 23, 2023
77fc7e4
FEDX-534 : Updated runs on instance
alishadalal-wk Nov 23, 2023
d75a6b0
FEDX-534 : Updated build job
alishadalal-wk Nov 23, 2023
2628022
FEDX-534 : Updated build job
alishadalal-wk Nov 23, 2023
e92cb74
FEDX-534 : Updated install dep step
alishadalal-wk Nov 23, 2023
7caec06
FEDX-534 : Updated build job
alishadalal-wk Nov 23, 2023
450fdae
FEDX-534 : Updated instance size?
alishadalal-wk Nov 23, 2023
23981c7
FEDX-534 : Updated instance size?
alishadalal-wk Nov 23, 2023
7617f94
FEDX-534 : Updated build job
alishadalal-wk Nov 23, 2023
30eb8a8
FEDX-534 : Updated build job
alishadalal-wk Nov 23, 2023
a807365
FEDX-534 : Removed dart_dev_workiva Dep & its code
alishadalal-wk Nov 23, 2023
19a8ca4
FEDX-534 : Updated dart pub get action
alishadalal-wk Nov 23, 2023
9ad4b83
FEDX-534 : Updated dart pub get action
alishadalal-wk Nov 23, 2023
aabd777
FEDX-534 : Updated dart install, validate, format & analyze action
alishadalal-wk Nov 23, 2023
71f3b1b
FEDX-534 : Updated dart install, validate, format & analyze action
alishadalal-wk Nov 23, 2023
fc1eba9
FEDX-534 : Added test job
alishadalal-wk Nov 23, 2023
d16273f
FEDX-534 : Updated test job
alishadalal-wk Nov 23, 2023
81b9c03
FEDX-534 : Updated test job
alishadalal-wk Nov 23, 2023
bc97a43
FEDX-534 : Updated test job
alishadalal-wk Nov 23, 2023
a311775
FEDX-534 : Removed skynet file
alishadalal-wk Nov 23, 2023
d876c32
FEDX-534 : code cleanup
alishadalal-wk Nov 23, 2023
d9c7adc
FEDX-534 : Updated test job
alishadalal-wk Nov 24, 2023
5ee14d6
FEDX-534 : Updated test ddc
alishadalal-wk Nov 24, 2023
25d74f1
FEDX-534 : Updated test ddc job
alishadalal-wk Nov 24, 2023
4f4959e
FEDX-534 : Updated test ddc job
alishadalal-wk Nov 24, 2023
9d8b3a4
FEDX-534 : Reverted job changes
alishadalal-wk Nov 24, 2023
ee10474
FEDX-534 : Added audit job
alishadalal-wk Nov 24, 2023
b4022f6
FEDX-534 : Updated audit job
alishadalal-wk Nov 24, 2023
b2ae5b7
FEDX-534 : Updated audit job
alishadalal-wk Nov 24, 2023
816cdc7
FEDX-534 : Updated audit job
alishadalal-wk Nov 24, 2023
ec85611
FEDX-534 : Removed audit job
alishadalal-wk Nov 24, 2023
6b9fbeb
FEDX-534 : Added test reports
alishadalal-wk Nov 24, 2023
8fc3d73
FEDX-534 : ddc tests check
alishadalal-wk Nov 24, 2023
bc83a19
FEDX-534 : added dart2js check
alishadalal-wk Nov 24, 2023
cf832ea
FEDX-534 : code cleanup
alishadalal-wk Nov 24, 2023
e94c197
FEDX-534 : resolve review comments, readded skynet yaml file
alishadalal-wk Nov 28, 2023
c31c37c
FEDX-534 : Updated job names
alishadalal-wk Nov 28, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 75 additions & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
name: CI

on:
pull_request:
push:
branches:
- master
- _integration/**/*
- test_consume_workiva/**
tags:
- '**'

jobs:
standard-dart-checks:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: dart-lang/setup-dart@v1
with:
sdk: 2.19.6

- name: Print Dart SDK version
run: dart --version

- name: Install dependencies
run: dart pub get

- name: Validate code
run: dart run dependency_validator

- name: Check format
run: dart run dart_dev format --check

- name: Analyze code
run: dart run dart_dev analyze

test-ddc:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: dart-lang/setup-dart@v1
with:
sdk: 2.19.6

- name: Install dependencies
run: dart pub get

- name: Run tests (DDC)
run: dart run build_runner test -- --file-reporter json:reports/ddc/test-results.json

- name: Upload Unit Test Results
uses: actions/upload-artifact@v2
with:
name: ddc-test-results
path: reports/ddc/test-results.json

test-dart2js:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: dart-lang/setup-dart@v1
with:
sdk: 2.19.6

- name: Install dependencies
run: dart pub get

- name: Run tests (dart2js)
run: dart run build_runner test -r -- --file-reporter json:reports/dart2js/test-results.json

- name: Upload Unit Test Results
uses: actions/upload-artifact@v2
with:
name: dart2js-test-results
path: reports/dart2js/test-results.json
7 changes: 2 additions & 5 deletions pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,9 @@ environment:
sdk: '>=2.12.0 <3.0.0'

dev_dependencies:
build_runner: ^2.0.0
build_test: ^2.0.0
dart_dev: ^4.0.0
dart_dev_workiva:
hosted:
name: dart_dev_workiva
url: https://pub.workiva.org
version: ^2.0.1
dart_style: ^2.0.0
dependency_validator: ^3.0.0
test: ^1.16.5
Expand Down
65 changes: 7 additions & 58 deletions skynet.yaml
Original file line number Diff line number Diff line change
@@ -1,63 +1,12 @@
name: standard-dart-checks
description: Quality checks (analyze, format, dependency validator)
contact: 'Frontend Architecture / #support-frontend-architecture'
image: drydock.workiva.net/workiva/dart2_base_image:2
size: large
timeout: eternal
description: contextual_message_no-op
image: drydock.workiva.net/workiva/skynet-images:bash_curl_alpinelatest-latest

scripts:
- merge_branch.sh master
- timeout 5m dart pub get
- dart analyze
- dart run dart_dev format --check
- dart run dependency_validator

---

name: semver-audit
description: Runs the semver-audit tool to check for minor and major changes
contact: 'Frontend Architecture / #support-frontend-architecture'

image: drydock.workiva.net/workiva/dart2_base_image:2
size: small
timeout: 300

scripts:
- merge_branch.sh master
- dart pub global activate --hosted-url https://pub.workiva.org semver_audit ^2.0.3
- timeout 5m dart pub get
- semver_audit report

---

name: unit-tests-dev
description: Runs unit tests compiled with DDC
contact: 'Frontend Architecture / #support-frontend-architecture'
image: drydock.workiva.net/workiva/dart_unit_test_image:2
size: large
timeout: eternal

artifacts: /testing/test-reports
test-reports: /testing/test-reports

scripts:
- merge_branch.sh master
- timeout 5m dart pub get
- dart run dart_dev test --xunit

---

name: unit-tests-release
description: Runs unit tests compiled with dart2js
contact: 'Frontend Architecture / #support-frontend-architecture'
image: drydock.workiva.net/workiva/dart_unit_test_image:2
size: large
timeout: eternal
timeout: short

artifacts: /testing/test-reports
test-reports: /testing/test-reports
run:
on-tag: true
on-pull-request: true

scripts:
- merge_branch.sh master
- timeout 5m dart pub get
- dart run dart_dev test --xunit --release
- echo "no-op, tests run in gha"
6 changes: 0 additions & 6 deletions tool/dart_dev/config.dart

This file was deleted.

Loading