Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O11Y-3369: Migrate opentelemetry-dart to GHA #134

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

michaelyeager-wf
Copy link
Contributor

Which problem is this PR solving?

GHA "publish" workflow currently contains incorrect regex, which prevents the workflow from triggering properly. Workflow regex should conform to the following conventions: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet

This PR updates the tag regex which triggers a publish to pub.dev.

How Has This Been Tested?

  • Pushed an RC tag to my fork containing these changes.
  • Confirmed that "publish" workflow started execution.

https://github.com/michaelyeager-wf/opentelemetry-dart/actions/runs/6701443021/job/18208880198
Failure is expected because the referenced reusable workflow does not have access to my fork.

 - Update publish tags regex.
@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

Copy link
Contributor

@kennytrytek-wf kennytrytek-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelyeager-wf
Copy link
Contributor Author

  • Pushed an RC tag to my fork containing these changes.
  • Confirmed that "publish" workflow started execution.

https://github.com/michaelyeager-wf/opentelemetry-dart/actions/runs/6701443021/job/18208880198

QA +1

@michaelyeager-wf
Copy link
Contributor Author

@Workiva/release-management-p

@michaelyeager-wf michaelyeager-wf merged commit f27a4ba into master Oct 31, 2023
1 check passed
@dancleereman-wf
Copy link

RM +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants