Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opentelemetry-dart 0.17.0 #135

Merged
merged 14 commits into from
Nov 10, 2023
Merged

opentelemetry-dart 0.17.0 #135

merged 14 commits into from
Nov 10, 2023

Conversation

michaelyeager-wf
Copy link
Contributor

Which problem is this PR solving?

This PR combines changes and updates from the following branch PRs:

How Has This Been Tested?

  • Confirm that unit tests pass following these changes.
  • Loaded these changes in a small testing application and confirmed that it can be used to properly emit traces.

@michaelyeager-wf
O11Y-3138: Remove Deprecated SDK exports for SpanContext, TraceState,
8e8447c 
and W3cTraceContextPropagator.
@michaelyeager-wf
O11Y-1786: Implement Read/Write Spans
d06d935
@michaelyeager-wf
O11Y-1786: Implement Read/Write Spans
ebdd3ad 
 - Interface corrections for WebTracerProvider.
@michaelyeager-wf
O11Y-1786: Implement Read/Write Spans
bb6fe6e 
 - Interface corrections for Tracer.
@michaelyeager-wf
O11Y-3138: Improve Adherence to Specification
b99b91d 
 - Stop exporting NonRecordingSpan.
 - Transition SDK Tracer to protected constant constructor with
   non-optional arguments.
 - Transition SDK Span to protected constructor with non-optional
   arguments.
 - Transition Span.setStatus to positional optional parameters.
@michaelyeager-wf
O11Y-3138: Improve Adherence to Specification
60345c4 
 - Return opentelemetry-proto to v0.9.0.
@michaelyeager-wf
O11Y-3138: Improve Adherence to Specification
9d9000c 
 - Return opentelemetry-proto to v0.9.0.
@michaelyeager-wf
O11Y-3603: Deprecate InstrumentationLibrary for InstrumentationScope
115c0f1
@michaelyeager-wf
O11Y-3603: Deprecate InstrumentationLibrary for InstrumentationScope
6ffbe21 
 - Update OpenTelemetry Proto to latest version.
@michaelyeager-wf
O11Y-3111: Migrate OpenTelemetry Dart to null-safety
204b16b
@michaelyeager-wf
Fixes for MeterProvider unit tests.
82c7480
@aviary3-wk
Copy link

aviary3-wk commented Nov 9, 2023 •
edited by aviary2-wf
Loading

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@michaelyeager-wf
Copy link
Contributor Author

@aviary-wf

robbecker-wf
robbecker-wf previously approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@robbecker-wf robbecker-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each sub-pr has been reviewed. Each one was squashed and merged without conflict. LGTM assuming testing goes well.

@michaelyeager-wf
Copy link
Contributor Author

Loaded these changes in a small testing application. Confirmed that it can be used to properly emit traces. Confirmed that context propagates appropriately.

QA +1

@robbecker-wf
Copy link
Member

@aviary-wf Can you try running again?

robbecker-wf
robbecker-wf previously approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@robbecker-wf robbecker-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving again after removing the Dockerfile

@michaelyeager-wf
Copy link
Contributor Author

Loaded these changes in a small testing application. Confirmed that it can be used to properly emit traces. Confirmed that context propagates appropriately.

QA +1

@robbecker-wf
Copy link
Member

@Workiva/release-management-p

@robbecker-wf robbecker-wf reopened this Nov 10, 2023
@michaelyeager-wf
Copy link
Contributor Author

Loaded these changes in a small testing application. Confirmed that it can be used to properly emit traces. Confirmed that context propagates appropriately.

QA +1

robbecker-wf
robbecker-wf approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@robbecker-wf robbecker-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10 again

@michaelyeager-wf
Copy link
Contributor Author

Loaded these changes in a small testing application. Confirmed that it can be used to properly emit traces. Confirmed that context propagates appropriately.

QA +1

rmconsole-wf
rmconsole-wf approved these changes Nov 10, 2023
View reviewed changes
Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole3-wf rmconsole3-wf merged commit 4ae2d1a into master Nov 10, 2023
1 check passed
@rmconsole3-wf rmconsole3-wf deleted the myeager-wf/v0.17.0 branch November 10, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbecker-wf robbecker-wf robbecker-wf approved these changes

@rmconsole-wf rmconsole-wf rmconsole-wf approved these changes

@blakeroberts-wk blakeroberts-wk blakeroberts-wk left review comments

@evanweible-wf evanweible-wf Awaiting requested review from evanweible-wf evanweible-wf is a code owner

@dustinlessard-wf dustinlessard-wf Awaiting requested review from dustinlessard-wf

Assignees
No one assigned
Labels
Merge Requirements Met RM Ready semver: Minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@michaelyeager-wf @aviary3-wk @robbecker-wf @rmconsole-wf @blakeroberts-wk @rmconsole3-wf