O11Y-3733: opentelemetry-dart: Implement Improvements to Timer in BatchSpanProcessor #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelyeager-wf
requested review from
evanweible-wf,
dustinlessard-wf and
a team
as code owners
|
Loaded these changes in a small testing application and confirmed that it can be used to properly emit traces. QA +1 |
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
kennytrytek-wf
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
This behavior is in accordance with the spec.
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#batching-processor
One thing that is missing is immediate batch export once maximum batch size has been reached, but that was missing before too. It should be added separately.
⛄
keruitan-wk
approved these changes
Nov 28, 2023
changliu-wk
approved these changes
Nov 28, 2023
blakeroberts-wk
approved these changes
Nov 28, 2023
|
@Workiva/release-management-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The implementation of Timer for periodic export of spans from BatchSpanProcessor is convoluted and not as null-safe as it should be.
This PR simplifies how BatchSpanProcessor uses Timer in emitting spans.
How Has This Been Tested?