Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEA-3236: Latest scip cli and diagnostic snapshot generation #112

Merged
merged 5 commits into from
Jan 28, 2024

Conversation

matthewnitschke-wk
Copy link
Contributor

@matthewnitschke-wk matthewnitschke-wk commented Jan 25, 2024

FEA-3236

Issue Status

sourcegraph/scip#226 added diagnostics in snapshot results

This pr removes the janky json parsing diagnostic snapshot generation in favor of the official one provided by the scip cli

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@matthewnitschke-wk matthewnitschke-wk changed the title latest scip cli and diagnostic snapshot generation Latest scip cli and diagnostic snapshot generation Jan 25, 2024
@matthewnitschke-wk matthewnitschke-wk marked this pull request as ready for review January 25, 2024 21:36
@bender-wk bender-wk changed the title Latest scip cli and diagnostic snapshot generation FEA-3236: Latest scip cli and diagnostic snapshot generation Jan 25, 2024
@matthewnitschke-wk
Copy link
Contributor Author

QA +1

  • CI does indeed pass

🚀 @Workiva/release-management-p 🚢

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole2-wf rmconsole2-wf merged commit 55adb87 into master Jan 28, 2024
12 checks passed
@rmconsole2-wf rmconsole2-wf deleted the latest_scip_cli branch January 28, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants