Skip to content

Commit

Permalink
FEDX-1707: code cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
dustinlessard-wf committed Oct 17, 2024
1 parent 6f87a87 commit 61a43ee
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 14 deletions.
8 changes: 1 addition & 7 deletions lib/src/lifecycle_module.dart
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ library w_module.src.lifecycle_module;
import 'dart:async';

import 'package:logging/logging.dart';
import 'package:meta/meta.dart' show mustCallSuper, protected, required;
import 'package:meta/meta.dart' show mustCallSuper, protected;
import 'package:opentracing/opentracing.dart';
import 'package:w_common/disposable.dart';

Expand Down Expand Up @@ -178,9 +178,6 @@ abstract class LifecycleModule extends SimpleModule with Disposable {
}

final tracer = globalTracer();
if (tracer == null) {
return null;
}

List<Reference> references = [];
if (_parentContext != null) {
Expand Down Expand Up @@ -230,9 +227,6 @@ abstract class LifecycleModule extends SimpleModule with Disposable {
}

final tracer = globalTracer();
if (tracer == null) {
return null;
}

tracer
.startSpan(
Expand Down
4 changes: 0 additions & 4 deletions test/event_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@ void main() {
event = Event<String>(key);
});

test('should inherit from Stream', () {
expect(event is Stream, isTrue);
});

test('should provide means to listen to the stream it was created from',
() async {
Completer completer = Completer();
Expand Down
3 changes: 0 additions & 3 deletions test/utils.dart
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@ class _LogLevelMatcher extends Matcher {

@override
bool matches(dynamic record, Map matchState) {
if (_level == null) {
return false;
}
if (record is LogRecord) {
return record.level == _level;
}
Expand Down

0 comments on commit 61a43ee

Please sign in to comment.