Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Ensure all child modules get unloaded" #241

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Revert "Ensure all child modules get unloaded" #241

merged 1 commit into from
Mar 1, 2024

Conversation

dustyholmes-wf
Copy link
Contributor

Reverts #239

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

alexandercampbell-wk
alexandercampbell-wk approved these changes Mar 1, 2024
View reviewed changes
Copy link

@alexandercampbell-wk alexandercampbell-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@alexandercampbell-wk
Copy link

For posterity:
This revert is necessary because (quoting from Dusty's Slack message):

~800 test failures in the update…
[...] Our mock modules do not always emit the didDispose.

@dustyholmes-wf
Copy link
Contributor Author

QA+1

clean revert

This PR is ready for merging @Workiva/release-management-p

rmconsole-wf
rmconsole-wf approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole3-wf rmconsole3-wf merged commit 6db8367 into master Mar 1, 2024
8 checks passed
@rmconsole3-wf rmconsole3-wf deleted the revert-239-unload-modules-loaded-after-unload-starts branch March 1, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandercampbell-wk alexandercampbell-wk alexandercampbell-wk approved these changes

@rmconsole-wf rmconsole-wf rmconsole-wf approved these changes

@kendalsickels-wf kendalsickels-wf kendalsickels-wf approved these changes

Assignees
No one assigned
Labels
Merge Requirements Met RM Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dustyholmes-wf @aviary3-wk @alexandercampbell-wk @kendalsickels-wf @rmconsole-wf @rmconsole3-wf