Dispose modules during onLoad if parent is unloaded/unloading

[dustyholmes-wf]

Motivation

When a child module is loaded, it is possible for the unload of the parent to complete before the onWillLoadChildModule handler executes.

This is a second attempt at a safe implementation of #239.

Changes

Check unloading/unloaded and just dispose in that handler instead.

Release Notes

Fix bug where child module loads during the unload of the parent causing Bad State exceptions.

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

• Tests were updated and provide good coverage of the changeset and other affected code
• Manual testing was performed if needed
  • Steps from PR author:
  • Anything falling under manual testing criteria outlined in CONTRIBUTING.md

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

• A Frontend Architecture member has reviewed these changes
• There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
• For release PRs - Version metadata in Rosie comment is correct

[aviary3-wk]

Security Insights

No security relevant content was detected by automated scans.

Action Items

• Review PR for security impact; comment "security review required" if needed or unsure
• Verify aviary.yaml coverage of security relevant code

---

Questions or Comments? Reach out on Slack: #support-infosec.

[dustyholmes-wf]

Testing this against DPC to verify I'm not causing some new timing problem to surface, as I did last time.

https://github.com/Workiva/doc_plat_client/compare/test_consume_workiva/w_module-unload-modules-before-dispose?expand=1

[todbachman-wf]

+10
@Workiva/release-management-pp

[rmconsole-wf]

+1 from RM