Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow consumption of null-safe over_react and over_react_test versions #245

Merged

Conversation

sourcegraph-wk
Copy link

@sourcegraph-wk sourcegraph-wk commented Mar 27, 2024

This PR widens the allowable version ranges to over_react 5.0.0 / over_react_test 3.0.0 so that all repos at Workiva can consume without updating all repositories in lock step.
These major versions are a critical step towards unlocking null safety in Workiva's Dart ecosystem - and have already been tested and verified as safe for consumption using the w_module test PR listed in this SourceGraph batch.
Due to the exhaustive consumption testing already performed in this repository by the FED team prior to releasing over_react 5.0.0, these changes can be merged without approval from a FED team member.


For more information about these changes, see this post in the #frontend-advocate-network channel. Otherwise, reach out to the FED team in #support-ui-platform with any specific questions or concerns.

Created by Sourcegraph batch change Workiva/over_react-5.0_raise-upper.

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@aaronlademann-wf aaronlademann-wf marked this pull request as ready for review March 27, 2024 21:51
Copy link
Contributor

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1/+10

@Workiva/release-management-pp

Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole7-wk rmconsole7-wk merged commit 5032fcb into master Mar 27, 2024
8 checks passed
@rmconsole7-wk rmconsole7-wk deleted the batch/fed/over_react_5/p1_raise_upper/w_module branch March 27, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants