Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#345) Set new dependencies to account for Flutter 2 requirements #346

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zmeggyesi
Copy link

@zmeggyesi zmeggyesi commented Apr 8, 2021

http_parser and uuid are transitively depended on in many packages, especially logging, so this package must follow along with the dependencies.
Still hitting a block with analyzer and over_react, however.

Fixes #345

Motivation

Since Flutter 2 has been de facto mandated since its release (by Google upgrading all its core packages and requiring users to do so as well), w_transport should be upgraded to match. However, the nature of dependencies with other Workiva-internal packages is making this quite difficult to do form the outside.

Changes

New dependency version in pubspec.

Release Notes

Upgrade dependencies to enable Flutter 2 use.

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

`http_parser` and `uuid` are transitively depended on in many packages, especially `logging`, so this package must follow along with the dependencies.
Still hitting a block with `analyzer` and `over_react`, however.
@zmeggyesi zmeggyesi changed the title Set new dependencies to account for Flutter 2 requirements (#345) Set new dependencies to account for Flutter 2 requirements Apr 8, 2021
@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

This required the (hopefully temporary) removal of the `examples` directory as `over_react` conflicted with other packages. Additionally, due to `dart_dev`'s dependencies, some packages need to be overwritten.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flutter 2 support
2 participants