Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V5 #353

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

V5 #353

wants to merge 2 commits into from

Conversation

evanweible-wf
Copy link
Contributor

Changes

  • Remove all deprecated APIs
  • Update changelog

Testing

  • Given the scope and nature of changes, we'll want to do some consumer testing prior to release.

@aviary-wf
Copy link

Security Insights

The items listed below may not capture all security relevant changes. Before providing a security review, be sure to review the entire PR for security impact.

(2) Security relevant changes were detected
  • Watched keyword withCredentials in lib/src/http/client.dart line(s) ['24', '64'] removed
  • Watched keyword withCredentials in lib/src/http/http_client.dart line(s) ['81'] added

    • Action Items

    • Obtain a security review; reviewer should pay special attention to insights listed above
    • Verify aviary.yaml coverage of security relevant code

    Questions or Comments? Reach out on Slack: #support-infosec.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers
    No reviews
    Assignees
    No one assigned
    Labels
    Security Review Required
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @evanweible-wf @aviary-wf