Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEA-4627: fedx_codeowners_file #45

Merged
merged 6 commits into from
Sep 5, 2024

Conversation

sourcegraph-wk
Copy link

@sourcegraph-wk sourcegraph-wk commented Aug 22, 2024

FEA-4627

Issue Status

Adds a CODEOWNERS file to all of the repos officially owned by the fedx
Repo ownership was decided by repo:has.meta(team:fedx) so therefore transitively CID

Created by Sourcegraph batch change Workiva/fedx_codeowners_file.

@aviary3-wk
Copy link

aviary3-wk commented Aug 22, 2024

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@matthewnitschke-wk matthewnitschke-wk requested review from a team and removed request for a team August 23, 2024 00:47
@matthewnitschke-wk matthewnitschke-wk marked this pull request as ready for review September 4, 2024 14:24
@matthewnitschke-wk matthewnitschke-wk requested a review from a team September 4, 2024 14:24
@bender-wk bender-wk changed the title fedx_codeowners_file FEA-4627: fedx_codeowners_file Sep 4, 2024
gha:
patterns: ["*"]
- package-ecosystem: pub
versioning-strategy: increase
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we'll need to avoid major version raises or not?

Copy link
Member

@robbecker-wf robbecker-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good as-is. We can always review or change dependabot major version bump strategy if it becomes a problem.

@matthewnitschke-wk
Copy link
Contributor

QA +1

  • CI does indeed pass, changes just to CI

🚀 @Workiva/release-management-p 🚢

@matthewnitschke-wk
Copy link
Contributor

🚀 @Workiva/release-management-p 🚢

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole3-wf rmconsole3-wf merged commit fffefbd into master Sep 5, 2024
13 checks passed
@rmconsole3-wf rmconsole3-wf deleted the batch/fedx_codeowners_file/webdev_proxy branch September 5, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants