Refactor process parquet #124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvantricht
requested changes
Dec 13, 2024
presto/utils.py
Outdated
| takes into account updated start_date and end_date; available_timesteps | ||
| holds the absolute number of timesteps that for which observations are | ||
| - computing the number of available timesteps in the timeseries; | ||
| it represents the absolute number of timesteps for which observations are | ||
| available; it cannot be less than NUM_TIMESTEPS; if this is the case, |
There was a problem hiding this comment.
How is this now more flexible for number of timesteps if the latter is still imported from presto-worldcereal. Doesn't seem to be a flexible parameter?
presto/utils.py
Outdated
| ) | ||
| index_columns.append("available_timesteps") | ||
|
|
||
| # check for missing timestamps in the middle of timeseries |
There was a problem hiding this comment.
Does this comment belong to the actual code on the next line (being the concatenation of dataframes)?
There was a problem hiding this comment.
this part is now removed b4964b0
| @@ -314,6 +301,7 @@ def process_parquet(df: pd.DataFrame) -> pd.DataFrame: | |||
| df = pd.concat([df, dummy_df]) | |||
|
|
|||
| # finally pivot the dataframe | |||
| index_columns = list(np.unique(index_columns)) | |||
| df_pivot = df.pivot(index=index_columns, columns="timestamp_ind", values=feature_columns) | |||
| df_pivot = df_pivot.fillna(NODATAVALUE) | |||
There was a problem hiding this comment.
this is the actual filling of timestamps "in the middle" ?
There was a problem hiding this comment.
this part is now actually obselete, because ranking function that is used to create timestamp_ind does not make any gaps that might require filling in. I removed it for now b4964b0
| @@ -716,7 +696,7 @@ def prep_dataframe( | |||
| # SAR cannot equal 0.0 since we take the log of it | |||
| cols = [f"SAR-{s}-ts{t}-20m" for s in ["VV", "VH"] for t in range(36 if dekadal else 12)] | |||
|
|
|||
| df = df.drop_duplicates(subset=["sample_id", "lat", "lon", "end_date"]) | |||
| df = df.drop_duplicates(subset=["sample_id", "lat", "lon", "start_date"]) | |||
added 8 commits
December 13, 2024 10:44
…inferred observations frequency
…es not have gaps; also fixed the indexing so that timestamp_ind starts with 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
["sample_id", "timestamp", "lat", "lon"]Something to keep in mind: