-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
139-slope-collection #155
139-slope-collection #155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor remarks, except for the OpenEO client version
Also I would move the slope computation directly to the PatchFeatureExtractor superclass in GFMAP in the future, as it can be useful to everyone
@@ -41,7 +41,7 @@ dependencies = [ | |||
"numpy<2.0.0", | |||
"netcdf4<=1.6.4", | |||
"h5netcdf>=1.1.0", | |||
"openeo>=0.29.0", | |||
"openeo>=0.31.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would wait for this ticket to close before changing the OpenEO version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok but we can't merge this PR without bumping the version because the new slope collection cannot be loaded with 0.29.0
. Something in the python client changed and the former version cannot work with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'll try to close this issue GFMAP today
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kvantricht Nevermind sorry! this issue will come with Version 0.32 and the feature is not yet merged on the client repository
yeah but the way it's implemented now (especially with the required change to force computation at 20m) is probably not generic enough. I think what would be better instead is a slope (or terrain attributes) process in openEO, which can then be accessed in GFMAP in a transparent way. |
Load slope from global collection when on CDSE backend