Feat(packs): Exporting & Importing Questions #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d113373.
mezotv
requested changes
Dec 22, 2024
There was a problem hiding this comment.
Great job with this I had a few issues with it tho:
- Can the green color be a bit lighter the contrast currently isnt great,
- I think the export button should only work when there is actual questions added.
- I ran into this small ui issue when testing with a longer question
Apart from those it seems to work and look great!
|
One thing I forgot to mention is that we should show the user what was wrong in his upload instead of just saying the validation failed. |
mezotv
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Demonstration
https://github.com/user-attachments/assets/d49892d7-4cef-4f20-93cc-14c8b6456c25
https://github.com/user-attachments/assets/348b20d6-e513-4eca-8f9c-704a7fcd37a7