Merge pull request #31 from half-drop/fabric-1.20.1

Apply Persistent mode fix for 1.20.1
Wudji · Nov 12, 2024 · fdffa76 · fdffa76
2 parents cecab93 + 485ca79
commit fdffa76
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/src/main/java/troy/autofish/Autofish.java b/src/main/java/troy/autofish/Autofish.java
@@ -47,7 +47,10 @@ public Autofish(FabricModAutofish modAutofish) {
         modAutofish.getScheduler().scheduleRepeatingAction(10000, () -> {
             if(!modAutofish.getConfig().isPersistentMode()) return;
             if(!isHoldingFishingRod()) return;
-            if(hookExists && isBobberInWater()) return;
+            if(hookExists){
+                if(isBobberInWater()) return;
+                else useRod();
+            }
             if(modAutofish.getScheduler().isRecastQueued()) return;
 
             useRod();
@@ -234,7 +237,7 @@ public void switchToFirstRod(ClientPlayerEntity player) {
 
     public boolean isBobberInWater(){
         if(client.player != null && client.world != null && client.player.fishHook != null) {
-            return client.player.fishHook.isTouchingWater();
+            return client.world.getBlockState(client.player.fishHook.getBlockPos()).getBlock() == Blocks.WATER;
         } else{
             return false;
         }

diff --git a/src/main/java/troy/autofish/FabricModAutofish.java b/src/main/java/troy/autofish/FabricModAutofish.java
@@ -42,11 +42,13 @@ public void onInitializeClient() {
     }
 
     public void tick(MinecraftClient client) {
-        if (autofishGuiKey.wasPressed()) {
-            client.setScreen(AutofishScreenBuilder.buildScreen(this, client.currentScreen));
+        if (this.autofish != null){
+            if (autofishGuiKey.wasPressed()) {
+                client.setScreen(AutofishScreenBuilder.buildScreen(this, client.currentScreen));
+            }
+            autofish.tick(client);
+            scheduler.tick(client);
         }
-        autofish.tick(client);
-        scheduler.tick(client);
     }
 
     /**