minor refine

Signed-off-by: Lixia (Sylvia) Lei <[email protected]>

cmd/oras/root/repo/ls.go

@@ -77,13 +77,6 @@ func listRepository(cmd *cobra.Command, opts *repositoryOptions) error {
 	if err != nil {
 		return err
 	}
-
-	// TEST: to be removed
-	logger = logger.WithField("registry", reg.Reference.Host())
-	logger = logger.WithField("testkey", 123)
-	logger.Info("test info")
-	logger.Warn("test warn")
-
 	err = reg.Repositories(ctx, opts.last, func(repos []string) error {
 		for _, repo := range repos {
 			if subRepo, found := strings.CutPrefix(repo, opts.namespace); found {

internal/trace/context.go

@@ -37,7 +37,6 @@ func NewLogger(ctx context.Context, debug bool) (context.Context, logrus.FieldLo
 
 	logger := logrus.New()
 	logger.SetFormatter(&TextFormatter{})
-
 	logger.SetLevel(logLevel)
 	entry := logger.WithContext(ctx)
 	return context.WithValue(ctx, loggerKey, entry), entry

internal/trace/text_formatter.go

@@ -46,6 +46,5 @@ func (f *TextFormatter) Format(entry *logrus.Entry) ([]byte, error) {
 	}
 
 	buf.WriteString(logEntrySeperator)
-
 	return buf.Bytes(), nil
 }

internal/trace/transport.go

@@ -97,13 +97,14 @@ func logHeader(header http.Header) string {
 	return "   Empty header"
 }
 
-// TODO: test and docs
+// logResponseBody prints out the response body if it is printable and within
+// the size limit.
 func logResponseBody(resp *http.Response) string {
 	if resp.Body == nil || resp.Body == http.NoBody || resp.ContentLength <= 0 {
 		return ""
 	}
 	contentType := resp.Header.Get("Content-Type")
-	if !shouldPrint(contentType) {
+	if !isPrintableContentType(contentType) {
 		return fmt.Sprintf("   Body of content type \"%s\" is not printed", contentType)
 	}
 	if resp.ContentLength > payloadSizeLimit {
@@ -121,7 +122,8 @@ func logResponseBody(resp *http.Response) string {
 	return builder.String()
 }
 
-func shouldPrint(contentType string) bool {
+// isPrintableContentType returns true if the content of contentType is printable.
+func isPrintableContentType(contentType string) bool {
 	// JSON types
 	if strings.HasPrefix(contentType, "application/json") || strings.HasSuffix(contentType, "+json") {
 		return true