Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add CHAOSS metrics (EN + ZH) + refactoring #45

Merged
merged 6 commits into from
Sep 23, 2024

Conversation

Neilblaze
Copy link
Member

Description

Added new CHAOSS metrics (both EN & ZH), fixed links, and minor bugs.

🦄 Tested on local, build running successfully!

cc: @Peng99999, @frank-zsy / Partially resolves #24

Before submitting the PR, please take the following into consideration

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. If you don't have an issue, please create one.
  • Prefix your PR title with feat: , fix: , chore: , docs:, or refactor:.
  • The description should clearly illustrate what problems it solves.
  • Ensure that the commit messages follow our guidelines.
  • Resolve merge conflicts (if any).
  • Make sure that the current branch is upto date with the main branch.

@frank-zsy
Copy link
Contributor

Really amazing, you even change the CHAOSS URL to zh-CN for ZH language. I will modify the Chinese part.

Signed-off-by: frank-zsy <[email protected]>
@frank-zsy
Copy link
Contributor

/preview

Copy link

🪧The website for this PR is deployed at https://open-digger.cn/pull_45/

Signed-off-by: frank-zsy <[email protected]>
@frank-zsy
Copy link
Contributor

@Neilblaze I will merge the PR and congrats on finishing your OSPP task~ I will add X-lab metrics part later.

@frank-zsy frank-zsy merged commit a57fee7 into X-lab2017:master Sep 23, 2024
1 check passed
@Neilblaze
Copy link
Member Author

Neilblaze commented Sep 23, 2024

I will merge the PR and congrats on finishing your OSPP task~ I will add X-lab metrics part later.

Thank you @frank-zsy! 🥳
Also, just to let you know, I received an email from OSPP (a few days ago) that I must submit my Final Project Report by the 30th instant (I think 彭佳恒 also referred to the same on Slack). So, I'll start working on it now and will let you know if I need anything from you.

cc: @Peng99999

@Peng99999
Copy link
Collaborator

I will merge the PR and congrats on finishing your OSPP task~ I will add X-lab metrics part later.

Thank you @frank-zsy! 🥳 Also, just to let you know, I received an email from OSPP (a few days ago) that I must submit my Final Project Report by the 30th instant (I think 彭佳恒 also referred to the same on Slack). So, I'll start working on it now and will let you know if I need anything from you.

cc: @Peng99999

yeah, I have received the same email. Please don’t forget to write the OSPP final project report😄

@Neilblaze
Copy link
Member Author

@frank-zsy , @Peng99999 I've prepared the Final Project Report & it's accessible 👉🏼 " here "
Feedbacks are greatly appreciated! 🙏🏼

Once I receive the green signal, I'll submit! 😄

@frank-zsy
Copy link
Contributor

@Neilblaze Great report. There are several things:

  • I would like to use open source rather than open-source as an adj.
  • I think you can add a table about the contributions tracker part, like besides 4 PRs merged, there are 32 commits and 96 discussions, along with 2387 lines added. The numbers are really impressive.

@Neilblaze
Copy link
Member Author

Neilblaze commented Sep 24, 2024

@frank-zsy Noted! ✅
Thanks for the review, I've updated report & will submit the same by tomorrow! 😃

@Peng99999
Copy link
Collaborator

@Neilblaze I have seen the final report you submitted on the OSPP website. Once the review period begins (Oct. 1), I will approve your final report. The website looks more refined and visually appealing now, thank you for making a significant contribution. 👍👏 We also welcome you to continue contributing in the future.😃

@Neilblaze
Copy link
Member Author

@Peng99999 Thanks for the positive feedback, really appreciate that!
And to your point, yes, absolutely! I'd love to continue contributing to the OpenDigger website and improve it further! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants