-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add multiple new CHAOSS metrics (EN + ZH) #31
Conversation
Signed-off-by: neilblaze <[email protected]>
Signed-off-by: neilblaze <[email protected]>
/preview |
🪧The website for this PR is deployed at https://open-digger.cn/pull_31/ |
@Neilblaze Sorry that I have multiple lectures this week, I will come back to this PR later. |
Sounds good! |
I think it is really confusing to have so many metrics listed in a single category. Could we add another level to the metrics. Like:
Do you think this will help users to understand? |
@frank-zsy I had this concern while I was working on this, and you're right, we can surely optimize the view. But here's the catch, (prolly I'm nitpicking) if I do so, then the changes will be reflected holistically across the table, and since we're introducing a new column, a few rows shall remain empty, which I guess is fine 🤔 (or might look confusing, idk) I'll need to reiterate the changes in a new commit and link it to this PR, so just in case the new one (new commit with all the updated changes) looks bad, we can just simply reject that one, & proceed with the parent commit ( Ref: #28 (comment) |
I think it's fine to make the change, actually I think we do not really need the table in introduction page after we have detailed metrics description in each page. We can remove the table and refer to metrics index page instead. WDYT |
Personally, I feel that the table is an important part of the entire docs ecosystem since it acts as an index to every metrics. But sure, we can remove that. Or what I propose is we can make it modular and keep each respective section (say, This should in fact represent the same data but in a more convenient order, saving spaces across the page. Thoughts? |
That looks really cool! |
Signed-off-by: neilblaze <[email protected]>
Signed-off-by: neilblaze <[email protected]>
2377c79
to
47567e3
Compare
@Neilblaze Sorry, since I add a warning banner to preview deploy, I need to sync this PR with master branch but I miss operate with |
/preview |
🪧The website for this PR is deployed at https://open-digger.cn/pull_31/ |
No worries, I've pulled in the changes. It's on the work, I'll notify once I'm done with this :) |
…gger into new-metrics-v2
Signed-off-by: neilblaze <[email protected]>
Signed-off-by: neilblaze <[email protected]>
/preview |
🪧The website for this PR is deployed at https://open-digger.cn/pull_31/ |
@frank-zsy , @Peng99999 😎 We can get this one merged, while in the background I'll work on the |
so cool! |
@frank-zsy just a heads up, I've noticed an overflow of text in the warning banner 👇🏼 |
Yes, thanks, the banner should consider mobile layout. Fortunately this is just a preview deploy for PRs, nothing will be affected in production. I will look into how to fix this. |
@Neilblaze So this PR contains English and Chinese version of new metrics along with the new README menu in Chinese version, am I right? BTW, the banner height has been fixed. |
Signed-off-by: neilblaze <[email protected]> Co-Authored-By: Frank Zhao <[email protected]>
/preview |
🪧The website for this PR is deployed at https://open-digger.cn/pull_31/ |
Signed-off-by: neilblaze <[email protected]>
In this PR, I would like to update the metrics structure in the intro part as follow:
In this structure, there will be only 5 top levels which will make the doc much cleaner. |
Cool, I'll make the changes |
@Neilblaze No worries, I will make the change and add new commit to this PR. |
@frank-zsy That'll be awesome, and thanks for the help! 😃 |
Signed-off-by: frank-zsy <[email protected]>
/preview |
🪧The website for this PR is deployed at https://open-digger.cn/pull_31/ |
Signed-off-by: frank-zsy <[email protected]>
Signed-off-by: frank-zsy <[email protected]>
/preview |
🪧The website for this PR is deployed at https://open-digger.cn/pull_31/ |
Signed-off-by: frank-zsy <[email protected]>
/preview |
🪧The website for this PR is deployed at https://open-digger.cn/pull_31/ |
Signed-off-by: frank-zsy <[email protected]>
/preview |
🪧The website for this PR is deployed at https://open-digger.cn/pull_31/ |
@Neilblaze I updated the intro doc and also the sidebar of docs part to fit the category. The categories are collapsed except OpenRank in intro doc and sidebar. Can you check the content and the links in the PR. I think there are still some metrics missing related to issues and which from X-lab. |
Sure thing, I'll take a look and try to get things up and running. I'll also give a dry run for spell-check to ensure there's no typo.
Regarding the metrics related to issues, it's nearly done, and for the I'm redirecting from this actually 😅 |
@Neilblaze Yes, I will add the X-lab metrics. And actually issues and pull requests almost share the same metrics, we should manage how to present that. |
@frank-zsy yes, I noticed that. One way can be multiplexing both under a common name and keeping individual info under that 🤔 I'll try to come up with something (better) in the meantime. |
I would like to merge this PR first and raise PRs if there is anything to modify later. |
Signed-off-by: neilblaze <[email protected]>
↪️ Continued in #45 |
Description
Added new CHAOSS metrics (both
EN
&ZH
), for the following :[Update 11-09-24]: Refactored default views and added collapsibles.
🦄 Tested on local, build running successfully!
cc: @Peng99999, @frank-zsy / Partially resolves #24
Before submitting the PR, please take the following into consideration
feat:
,fix:
,chore:
,docs:
, orrefactor:
.main
branch.