Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add multiple new CHAOSS metrics (EN + ZH) #31

Merged
merged 15 commits into from
Sep 21, 2024

Conversation

Neilblaze
Copy link
Member

@Neilblaze Neilblaze commented Aug 1, 2024

Description

Added new CHAOSS metrics (both EN & ZH), for the following :

  • New Contributors
  • Change Request(s) Reviews
  • Change Requests Accepted
  • Change Requests Age
  • Change Requests Open
  • Change Requests Resolution Duration
  • Change Requests Response Time

[Update 11-09-24]: Refactored default views and added collapsibles.

🦄 Tested on local, build running successfully!

cc: @Peng99999, @frank-zsy / Partially resolves #24

Before submitting the PR, please take the following into consideration

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. If you don't have an issue, please create one.
  • Prefix your PR title with feat: , fix: , chore: , docs:, or refactor:.
  • The description should clearly illustrate what problems it solves.
  • Ensure that the commit messages follow our guidelines.
  • Resolve merge conflicts (if any).
  • Make sure that the current branch is upto date with the main branch.

@frank-zsy
Copy link
Contributor

/preview

Copy link

github-actions bot commented Aug 3, 2024

🪧The website for this PR is deployed at https://open-digger.cn/pull_31/

@frank-zsy
Copy link
Contributor

@Neilblaze Sorry that I have multiple lectures this week, I will come back to this PR later.

@Neilblaze
Copy link
Member Author

Sounds good!

@frank-zsy
Copy link
Contributor

I think it is really confusing to have so many metrics listed in a single category. Could we add another level to the metrics. Like:

  • OpenRank
  • Activity
  • General
    • Stars
    • Forks
  • Developers
    • Active contributors
    • New contributors
    • Inactive contributors
    • Activity dates and times
  • Issues
    • Issues new
    • Issues closed
    • Issues age
    • Issue comments
    • Issue response time
    • Issue resolution duration
  • Changes requests
    • just like issue...

Do you think this will help users to understand?

@Neilblaze
Copy link
Member Author

Neilblaze commented Aug 16, 2024

Do you think this will help users to understand?

@frank-zsy I had this concern while I was working on this, and you're right, we can surely optimize the view. But here's the catch, (prolly I'm nitpicking) if I do so, then the changes will be reflected holistically across the table, and since we're introducing a new column, a few rows shall remain empty, which I guess is fine 🤔 (or might look confusing, idk)

I'll need to reiterate the changes in a new commit and link it to this PR, so just in case the new one (new commit with all the updated changes) looks bad, we can just simply reject that one, & proceed with the parent commit (2377c79) itself.

Ref: #28 (comment)

@frank-zsy
Copy link
Contributor

I think it's fine to make the change, actually I think we do not really need the table in introduction page after we have detailed metrics description in each page. We can remove the table and refer to metrics index page instead. WDYT

@Neilblaze
Copy link
Member Author

I think it's fine to make the change, actually I think we do not really need the table in introduction page after we have detailed metrics description in each page. We can remove the table and refer to metrics index page instead. WDYT

Personally, I feel that the table is an important part of the entire docs ecosystem since it acts as an index to every metrics. But sure, we can remove that. Or what I propose is we can make it modular and keep each respective section (say, Activity, Developers, Issues, etc.) as subsections of the primary table itself, isolated into a collapsible component, like this 👇🏼

image

This should in fact represent the same data but in a more convenient order, saving spaces across the page. Thoughts?

@frank-zsy
Copy link
Contributor

That looks really cool!

@frank-zsy
Copy link
Contributor

@Neilblaze Sorry, since I add a warning banner to preview deploy, I need to sync this PR with master branch but I miss operate with rebase rather than pull, so I need to force push back.

@frank-zsy
Copy link
Contributor

/preview

Copy link

🪧The website for this PR is deployed at https://open-digger.cn/pull_31/

@Neilblaze
Copy link
Member Author

@Neilblaze Sorry, since I add a warning banner to preview deploy, I need to sync this PR with master branch but I miss operate with rebase rather than pull, so I need to force push back.

No worries, I've pulled in the changes. It's on the work, I'll notify once I'm done with this :)

@Neilblaze
Copy link
Member Author

/preview

Copy link

🪧The website for this PR is deployed at https://open-digger.cn/pull_31/

@Neilblaze
Copy link
Member Author

@frank-zsy , @Peng99999 😎

ScreenRec

We can get this one merged, while in the background I'll work on the EN variant, and will create a PR once I'm done with that 😄

@Peng99999
Copy link
Collaborator

@frank-zsy , @Peng99999 😎

ScreenRec ScreenRec

We can get this one merged, while in the background I'll work on the EN variant, and will create a PR once I'm done with that 😄

so cool!

@Neilblaze
Copy link
Member Author

Neilblaze commented Sep 12, 2024

@frank-zsy just a heads up, I've noticed an overflow of text in the warning banner 👇🏼

ScrRec

@frank-zsy
Copy link
Contributor

@frank-zsy just a heads up, I've noticed an overflow of text in the warning banner 👇🏼

ScrRec

Yes, thanks, the banner should consider mobile layout. Fortunately this is just a preview deploy for PRs, nothing will be affected in production. I will look into how to fix this.

@frank-zsy
Copy link
Contributor

@Neilblaze So this PR contains English and Chinese version of new metrics along with the new README menu in Chinese version, am I right?

BTW, the banner height has been fixed.

Signed-off-by: neilblaze <[email protected]>
Co-Authored-By: Frank Zhao <[email protected]>
@Neilblaze
Copy link
Member Author

/preview

Copy link

🪧The website for this PR is deployed at https://open-digger.cn/pull_31/

@frank-zsy
Copy link
Contributor

In this PR, I would like to update the metrics structure in the intro part as follow:

  • OpenRank
    • Repo global OpenRank
    • Developer global OpenRank
    • Repo community OpenRank
    • Developer community OpenRank
  • Statistics
    • Activity
    • Stars
    • Technical forks
    • Attention
    • Activity dates and times
  • Developers
    • New contributors
    • Contributors
    • Inactive contributors
    • Participants
    • Bus factor
  • Issues
    • Issues new
    • Issues closed
    • Issue comments
    • Issue response time
    • Issue resolution duration
    • Issue age
  • Change requests
    • Change requests
    • Change requests accepted
    • Change request reviews
    • Change request response time
    • Change request resolution duration
    • Change request age
    • Code change lines

In this structure, there will be only 5 top levels which will make the doc much cleaner.

@Neilblaze
Copy link
Member Author

Cool, I'll make the changes

@frank-zsy
Copy link
Contributor

@Neilblaze No worries, I will make the change and add new commit to this PR.

@Neilblaze
Copy link
Member Author

@frank-zsy That'll be awesome, and thanks for the help! 😃
I feel the order (which you proposed) seems much better in terms of interpretability for anyone, be it a layman or an experienced user, so thanks again for the heads up!

@frank-zsy
Copy link
Contributor

/preview

Copy link

🪧The website for this PR is deployed at https://open-digger.cn/pull_31/

@frank-zsy
Copy link
Contributor

/preview

Copy link

🪧The website for this PR is deployed at https://open-digger.cn/pull_31/

@frank-zsy
Copy link
Contributor

/preview

Copy link

🪧The website for this PR is deployed at https://open-digger.cn/pull_31/

@frank-zsy
Copy link
Contributor

/preview

Copy link

🪧The website for this PR is deployed at https://open-digger.cn/pull_31/

@frank-zsy
Copy link
Contributor

@Neilblaze I updated the intro doc and also the sidebar of docs part to fit the category. The categories are collapsed except OpenRank in intro doc and sidebar. Can you check the content and the links in the PR.

I think there are still some metrics missing related to issues and which from X-lab.

@Neilblaze
Copy link
Member Author

Neilblaze commented Sep 20, 2024

@Neilblaze I updated the intro doc and also the sidebar of docs part to fit the category. The categories are collapsed except OpenRank in intro doc and sidebar. Can you check the content and the links in the PR.

Sure thing, I'll take a look and try to get things up and running. I'll also give a dry run for spell-check to ensure there's no typo.

I think there are still some metrics missing related to issues and which from X-lab.

Regarding the metrics related to issues, it's nearly done, and for the x-lab, I intentionally kept it on hold (till now), because I think it might require your guidance :)

I'm redirecting from this actually 😅

"Metrics from X-lab are almost complex metrics involves calculation or even graph data structure, so we can add them at last."

@frank-zsy
Copy link
Contributor

@Neilblaze Yes, I will add the X-lab metrics. And actually issues and pull requests almost share the same metrics, we should manage how to present that.

@Neilblaze
Copy link
Member Author

... actually issues and pull requests almost share the same metrics, we should manage how to present that.

@frank-zsy yes, I noticed that. One way can be multiplexing both under a common name and keeping individual info under that 🤔

I'll try to come up with something (better) in the meantime.

@frank-zsy
Copy link
Contributor

I would like to merge this PR first and raise PRs if there is anything to modify later.

@frank-zsy frank-zsy merged commit 59c9d7e into X-lab2017:master Sep 21, 2024
1 check passed
Neilblaze referenced this pull request in Neilblaze/open-digger Sep 22, 2024
@Neilblaze
Copy link
Member Author

↪️ Continued in #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants