Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] Add my id as X-lab members labeled data into OpenDigger #916

Merged
merged 1 commit into from
Jul 20, 2022
Merged

[Data] Add my id as X-lab members labeled data into OpenDigger #916

merged 1 commit into from
Jul 20, 2022

Conversation

yoyo-wu98
Copy link
Contributor

@yoyo-wu98 yoyo-wu98 commented Jul 19, 2022 •
edited
Loading

According to the issue comment #864 (comment) , I want to add my id as X-lab members labeled data into OpenDigger.

But my account name has been changed so my actor_login can also be '1054096100'.
Should I mention it in the code comments?

SELECT actor_login, COUNT() as name_sum
FROM github_log.events where actor_id='29705275'
GROUP BY actor_login

[Out]
  actor_login  name_sum
0  1054096100       851
1   yoyo-wu98        21

So both actor_login have its own events.

Sorry if it makes something difficult:(

@yoyo-wu98
Add my id as X-lab members labeled data into OpenDigger
2c9f47f 
Add my id as X-lab members labeled data into OpenDigger.

But my account name has been changed so my `actor_login` can also be '1054096100'.

 Sorry if it makes the analysis difficult:(
@yoyo-wu98 yoyo-wu98 changed the title Add my id as X-lab members labeled data into OpenDigger [Data] Add my id as X-lab members labeled data into OpenDigger Jul 19, 2022
@frank-zsy
Copy link
Contributor

No worry about the login, actor_id is the only data we use to calculate. Comments about login and real name is just for human reading.

/approve

@open-digger-bot open-digger-bot bot added the pull/approved If a pull is approved, it will be automatically merged label Jul 20, 2022
@open-digger-bot open-digger-bot bot merged commit 982da92 into X-lab2017:master Jul 20, 2022
@yoyo-wu98
Copy link
Contributor Author

No worry about the login, actor_id is the only data we use to calculate. Comments about login and real name is just for human reading.

/approve

OK, thx.

@open-digger-bot open-digger-bot bot mentioned this pull request Jul 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pull/approved If a pull is approved, it will be automatically merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoyo-wu98 @frank-zsy