Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Adding dashboard link #54

Merged
merged 8 commits into from
Feb 17, 2023
Merged

[Feature] Adding dashboard link #54

merged 8 commits into from
Feb 17, 2023

Conversation

andyhuang18
Copy link
Collaborator

@andyhuang18 andyhuang18 commented Feb 14, 2023 •
edited by tyn1998
Loading

Related issues：

Details:

在open leaderboard上增加了一列，用于跳转到DataEase的dashboard上：

image

@zhicheng-ning
Copy link
Member

good job!

tyn1998
tyn1998 reviewed Feb 14, 2023
View reviewed changes
Copy link
Member

@tyn1998 tyn1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/components/table.js Outdated Show resolved Hide resolved
src/components/table.js Outdated Show resolved Hide resolved
src/components/table.js Outdated Show resolved Hide resolved
@tyn1998
Copy link
Member

tyn1998 commented Feb 14, 2023 •
edited
Loading

And suggestions on PR~

image

image

@andyhuang18
Copy link
Collaborator Author

Thanks for the suggestions! ^ ^

@wj23027
Copy link
Contributor

wj23027 commented Feb 17, 2023

Modified the problem mentioned by @tyn1998, and changed the dashboard link to an icon~
image

tyn1998
tyn1998 requested changes Feb 17, 2023
View reviewed changes
Copy link
Member

@tyn1998 tyn1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @wj23027. I tested this PR locally and it works fine:

image

But the code can still be improved a bit :)

src/components/table.js Outdated Show resolved Hide resolved
src/components/table.js Outdated Show resolved Hide resolved
src/components/table.js Outdated Show resolved Hide resolved
tyn1998
tyn1998 approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@tyn1998 tyn1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @andyhuang18 @wj23027 🌷

@tyn1998 tyn1998 merged commit a07b1dd into X-lab2017:main Feb 17, 2023
@zhicheng-ning zhicheng-ning mentioned this pull request Feb 18, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wj23027 wj23027 wj23027 left review comments

@tyn1998 tyn1998 tyn1998 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Adding Project Insight link
4 participants
@andyhuang18 @zhicheng-ning @tyn1998 @wj23027