-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XLS-35d: URITokens — Lightweight first-class NFTs #110
base: master
Are you sure you want to change the base?
Conversation
Could you write a one-paragraph explanation of what URITokens are, from first principles, without mentioning XLS-20? |
URITokens are Non-Fungible Tokens (NFTs) that exist as first-class on-ledger objects. They are uniquely identified by the hash of their issuer and Uniform Resource Identifier (URI), and can point to any digital content. Only one object per URI per account can exist on the ledger. The Issuer can set a flag to enable burning of the object in the future. Each owner's reserve is locked up as well upon ownership of the URIToken. They include the transaction types; |
I think you mean "Only one object per URI per account can exist on the ledger." ?
Aside from "data integrity", does this also make the JSON document immutable? |
It would essentially make the json immutable but only through a verification. If I used a URI that pointed to an IPNS then I could essentially change the json data, but then the digest check would be incorrect. So I don't know if saying "makes it immutable" is right. Also, I updated the uri duplicate nomenclature. |
I see. The explanation is helpful and looks good to me. I recommend adding it to the spec near the top in a section called "Abstract". The Abstract is a summary of the contents of the spec. The Abstract is part of the recommended template. |
Recommend adding a link to the proposed implementation in the spec. |
What about being able to create an Offer at the same time during It would be possible to set the |
@dangell7 - feel free to review the comments/questions above, at your convenience |
It looks like https://docs.xahau.network/technical/protocol-reference/transactions/transaction-types/uritokenmint |
If the reserves for ledger objects stay at 2 XRP per, this seems like it would be cost prohibitive. |
URITokens are Non-Fungible Tokens (NFTs) that exist as first-class on-ledger objects. They are uniquely identified by the hash of their issuer and Uniform Resource Identifier (URI), and can point to any digital content. Only one object per URI per account can exist on the ledger. The Issuer can set a flag to enable burning of the object in the future. Each owner's reserve is locked up as well upon ownership of the URIToken. They include the transaction types;
mint
,burn
,buy
,create sell offer
, andcancel sell offer
. Additionally, when minting a URIToken, users can choose whether or not to include a SHA-512 Half hash of the URI's contents to ensure data integrity.See the spec (in
Files changed
) for full details.Proposed implementation: XRPLF/rippled#4456