Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XLS-70d: Credentials #211

Merged
merged 26 commits into from
Sep 11, 2024
Merged

XLS-70d: Credentials #211

merged 26 commits into from
Sep 11, 2024

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Aug 2, 2024

Discussion thread can be found here: #202

@ximinez
Copy link
Collaborator

ximinez commented Aug 2, 2024

Should the directory be named "simulate"?

@mvadari
Copy link
Collaborator Author

mvadari commented Aug 2, 2024

Should the directory be named "simulate"?

Oops, copy-paste error - thanks!

Copy link
Collaborator

@mDuo13 mDuo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only worked my way through about half the spec so far but it mostly looks good. I've added a few comments where clarifications or rephrasing would be helpful.

XLS-0070d-credentials/README.md Outdated Show resolved Hide resolved
XLS-0070d-credentials/README.md Outdated Show resolved Hide resolved
XLS-0070d-credentials/README.md Outdated Show resolved Hide resolved
XLS-0070d-credentials/README.md Show resolved Hide resolved
XLS-0070d-credentials/README.md Outdated Show resolved Hide resolved
XLS-0070d-credentials/README.md Outdated Show resolved Hide resolved
XLS-0070d-credentials/README.md Outdated Show resolved Hide resolved
XLS-0070d-credentials/README.md Show resolved Hide resolved
XLS-0070d-credentials/README.md Outdated Show resolved Hide resolved
XLS-0070d-credentials/README.md Outdated Show resolved Hide resolved
XLS-0070d-credentials/README.md Show resolved Hide resolved
XLS-0070d-credentials/README.md Show resolved Hide resolved
XLS-0070d-credentials/README.md Show resolved Hide resolved
XLS-0070d-credentials/README.md Show resolved Hide resolved
XLS-0070d-credentials/README.md Outdated Show resolved Hide resolved
XLS-0070d-credentials/README.md Outdated Show resolved Hide resolved
XLS-0070d-credentials/README.md Outdated Show resolved Hide resolved
XLS-0070d-credentials/README.md Show resolved Hide resolved
XLS-0070d-credentials/README.md Show resolved Hide resolved
XLS-0070d-credentials/README.md Outdated Show resolved Hide resolved
@oleks-rip oleks-rip mentioned this pull request Aug 27, 2024
3 tasks
XLS-0070d-credentials/README.md Show resolved Hide resolved
XLS-0070d-credentials/README.md Show resolved Hide resolved
XLS-0070d-credentials/README.md Show resolved Hide resolved
XLS-0070d-credentials/README.md Show resolved Hide resolved
XLS-0070d-credentials/README.md Outdated Show resolved Hide resolved
XLS-0070d-credentials/README.md Outdated Show resolved Hide resolved
XLS-0070d-credentials/README.md Show resolved Hide resolved
XLS-0070d-credentials/README.md Show resolved Hide resolved
XLS-0070d-credentials/README.md Show resolved Hide resolved
XLS-0070d-credentials/README.md Show resolved Hide resolved
@mvadari
Copy link
Collaborator Author

mvadari commented Sep 10, 2024

@sappenin this is ready to merge. The remaining open questions will be addressed in future PRs.

@sappenin sappenin merged commit b2cd63f into XRPLF:master Sep 11, 2024
@mvadari mvadari deleted the xls-70d branch October 15, 2024 01:06
Copy link
Contributor

@tequdev tequdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XLS-0070d-credentials/README.md Show resolved Hide resolved
XLS-0070d-credentials/README.md Show resolved Hide resolved
XLS-0070d-credentials/README.md Show resolved Hide resolved
XLS-0070d-credentials/README.md Show resolved Hide resolved

## 9. RPC: `deposit_authorized`

The [`deposit_authorized` RPC method](https://xrpl.org/deposit_authorized.html) already exists on the XRPL. This proposal suggests some modifications to also support credential authorization.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link still redirects

XLS-0070d-credentials/README.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants