DRAFT: Ximinez/lending xls 66

[ximinez]

Base branch is #5224

High Level Overview of Change

Context of Change

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Refactor (non-breaking change that only restructures code)
• Performance (increase or change in throughput and/or latency)
• Tests (you added tests for code that already exists, or your new feature included in this PR)
• Documentation update
• Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
• Release

API Impact

• Public API: New feature (new methods and/or new fields)
• Public API: Breaking change (in general, breaking changes should only impact the next api_version)
• libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
• Peer protocol change (must be backward compatible or bump the peer protocol version)

[codecov]

Codecov Report

Attention: Patch coverage is 70.39627% with 254 lines in your changes missing coverage. Please review.

Project coverage is 78.0%. Comparing base (ab44cc3) to head (a697138).
Report is 6 commits behind head on develop.

Files with missing lines	Patch %	Lines
src/xrpld/ledger/detail/View.cpp	59.9%	85 Missing ⚠️
src/xrpld/app/misc/CredentialHelpers.cpp	20.4%	43 Missing ⚠️
src/xrpld/app/tx/detail/VaultCreate.cpp	79.4%	20 Missing ⚠️
src/xrpld/app/tx/detail/VaultDeposit.cpp	75.0%	19 Missing ⚠️
src/xrpld/app/tx/detail/VaultClawback.cpp	71.9%	16 Missing ⚠️
src/xrpld/app/tx/detail/VaultWithdraw.cpp	73.3%	16 Missing ⚠️
src/xrpld/app/tx/detail/VaultSet.cpp	71.1%	13 Missing ⚠️
src/xrpld/app/tx/detail/VaultDelete.cpp	80.0%	9 Missing ⚠️
src/libxrpl/protocol/STNumber.cpp	77.1%	8 Missing ⚠️
src/xrpld/app/tx/detail/MPTokenAuthorize.cpp	78.9%	4 Missing ⚠️
... and 9 more

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #5270     +/-   ##
=========================================
- Coverage     78.2%   78.0%   -0.2%     
=========================================
  Files          790     802     +12     
  Lines        67738   68616    +878     
  Branches      8177    8346    +169     
=========================================
+ Hits         52962   53497    +535     
- Misses       14776   15119    +343     

Files with missing lines	Coverage Δ
include/xrpl/json/json_value.h	98.5% <ø> (ø)
include/xrpl/protocol/AMMCore.h	100.0% <ø> (ø)
include/xrpl/protocol/Asset.h	95.2% <100.0%> (+0.5%)	⬆️
include/xrpl/protocol/Feature.h	100.0% <ø> (ø)
include/xrpl/protocol/IOUAmount.h	100.0% <ø> (ø)
include/xrpl/protocol/Indexes.h	100.0% <100.0%> (ø)
include/xrpl/protocol/MPTAmount.h	100.0% <ø> (ø)
include/xrpl/protocol/MPTIssue.h	100.0% <100.0%> (ø)
include/xrpl/protocol/SField.h	100.0% <ø> (ø)
include/xrpl/protocol/STAmount.h	95.5% <100.0%> (+0.3%)	⬆️
... and 55 more

... and 20 files with indirect coverage changes