Code

Credentials#759

Code

Merged

ckeshava merged 120 commits intoXRPLF:mainXRPLF/xrpl-py:mainfrom ckeshava:credckeshava/xrpl-py:credCopy head branch name to clipboardDec 21, 2024

+1,354-33

Commits

Commits on Oct 15, 2024

• Update definitions.json -- generated from the tip of rippled codebase at commit ea8e77ffec065cf1a8d1cd4517f9cebdab27cc17

  Show description for c7e1a15
  ckeshava

  committed
  c7e1a15

  Copy full SHA for c7e1a15

Commits on Oct 16, 2024

• Specify the CredentialCreate transaction

  ckeshava

  committed
  9d549c1

  Copy full SHA for 9d549c1

Commits on Oct 17, 2024

• Files relevant to the CredentialAccept transaction

  ckeshava

  committed
  8375c42

  Copy full SHA for 8375c42

• Files pertaining to the CredentialDelete transaction

  Show description for 8d810fc
  ckeshava

  committed
  8d810fc

  Copy full SHA for 8d810fc

Commits on Oct 18, 2024

• Files pertaining to DepositPreauth transaction are included in this commit

  Show description for 0a33121
  ckeshava

  committed
  0a33121

  Copy full SHA for 0a33121

• FIX: Update deposit_preauth integration tests to validate the transaction result code

  ckeshava

  committed
  fd8157d

  Copy full SHA for fd8157d

Commits on Oct 21, 2024

• Include account_objects RPC call to verify that cred ledger-object is successfully deleted

  Show description for 1d85bbb
  ckeshava

  committed
  1d85bbb

  Copy full SHA for 1d85bbb

• Updates to DepositAuthorized RPC

  ckeshava

  committed
  8ea12c4

  Copy full SHA for 8ea12c4

• address PR comments

  Show description for e4293be
  

  ckeshava

  and

  mvadari

  committed
  e4293be

  Copy full SHA for e4293be

Commits on Oct 22, 2024

• FIX: Use sum() method for error validation in DepositPreauth transaction model; Revert this file to an older version

  ckeshava

  committed
  60b7663

  Copy full SHA for 60b7663

• Update the definitions.json file without changing the format of the document

  ckeshava

  committed
  509ecd1

  Copy full SHA for 509ecd1

• Update base_model.py -- Use mypy with Python 3.8 suggestions

  ckeshava

  authored
  c0151c2

  Copy full SHA for c0151c2

Commits on Oct 24, 2024

• include fixAMM1_1 in the rippled.cfg file

  ckeshava

  committed
  48b8abc

  Copy full SHA for 48b8abc

• rearrange the LedgerEntryTypes in definitions.json

  ckeshava

  committed
  f476a51

  Copy full SHA for f476a51

Commits on Oct 25, 2024

• include amendments which are not in majority consensus yet

  ckeshava

  committed
  8b82c3d

  Copy full SHA for 8b82c3d

Commits on Oct 30, 2024

• Update tests/unit/models/transactions/test_account_delete.py

  Show description for a24ca5b
  

  ckeshava

  and

  coderabbitai[bot]

  authored
  a24ca5b

  Copy full SHA for a24ca5b

• Update tests/unit/models/transactions/test_credential_accept.py

  Show description for 4402f6d
  

  ckeshava

  and

  coderabbitai[bot]

  authored
  4402f6d

  Copy full SHA for 4402f6d

• refactor DepositPreauth transaction validity checks

  ckeshava

  committed
  22de7a3

  Copy full SHA for 22de7a3

• refactor suggestions from code-rabbit

  ckeshava

  committed
  f848bbd

  Copy full SHA for f848bbd

• Merge branch 'main' into cred

  ckeshava

  authored
  cb63c6d

  Copy full SHA for cb63c6d

Commits on Oct 31, 2024

• Update xrpl/models/transactions/deposit_preauth.py

  Show description for ffcf1bd
  

  ckeshava

  and

  mvadari

  authored
  ffcf1bd

  Copy full SHA for ffcf1bd

• Update xrpl/models/transactions/payment_channel_claim.py

  Show description for e498721
  

  ckeshava

  and

  mvadari

  authored
  e498721

  Copy full SHA for e498721

• Update xrpl/models/transactions/payment_channel_claim.py

  Show description for e5a0779
  

  ckeshava

  and

  mvadari

  authored
  e5a0779

  Copy full SHA for e5a0779

• remove unnecessary comments

  ckeshava

  committed
  ad4331a

  Copy full SHA for ad4331a

• update error msg in CredentialDelete txn

  ckeshava

  committed
  1a974fb

  Copy full SHA for 1a974fb

• Update xrpl/models/transactions/credential_accept.py

  Show description for 880a670
  

  ckeshava

  and

  mvadari

  authored
  880a670

  Copy full SHA for 880a670

• Update xrpl/models/transactions/credential_accept.py

  Show description for af67d78
  

  ckeshava

  and

  mvadari

  authored
  af67d78

  Copy full SHA for af67d78

• Update xrpl/models/transactions/credential_accept.py

  Show description for c50d611
  

  ckeshava

  and

  mvadari

  authored
  c50d611

  Copy full SHA for c50d611

• Update xrpl/models/transactions/credential_create.py

  Show description for 2c887aa
  

  ckeshava

  and

  mvadari

  authored
  2c887aa

  Copy full SHA for 2c887aa

• Update xrpl/models/transactions/credential_create.py

  Show description for 8468fcd
  

  ckeshava

  and

  mvadari

  authored
  8468fcd

  Copy full SHA for 8468fcd

• Update xrpl/models/transactions/credential_create.py

  Show description for bba054d
  

  ckeshava

  and

  mvadari

  authored
  bba054d

  Copy full SHA for bba054d

• Update xrpl/models/transactions/credential_create.py

  Show description for 6c0b958
  

  ckeshava

  and

  mvadari

  authored
  6c0b958

  Copy full SHA for 6c0b958

• Update xrpl/models/transactions/credential_create.py

  Show description for 7f68440
  

  ckeshava

  and

  mvadari

  authored
  7f68440

  Copy full SHA for 7f68440

• Update xrpl/models/transactions/credential_create.py

  Show description for 1485ae9
  

  ckeshava

  and

  mvadari

  authored
  1485ae9

  Copy full SHA for 1485ae9

• Update xrpl/models/transactions/credential_accept.py

  Show description for 27f8719
  

  ckeshava

  and

  mvadari

  authored
  27f8719

  Copy full SHA for 27f8719

• modified the structure of error collection

  ckeshava

  committed
  485d392

  Copy full SHA for 485d392

• modified error msg in DepositPreauth txn

  ckeshava

  committed
  562aa49

  Copy full SHA for 562aa49

• use _MAX_URI_LENGTH variable

  ckeshava

  committed
  d83f0d7

  Copy full SHA for d83f0d7

• Update all the unit tests as per the changes in model files

  ckeshava

  committed
  a188c1a

  Copy full SHA for a188c1a

• Use List instead of Set to store sequence of credentials

  ckeshava

  committed
  b97d6f3

  Copy full SHA for b97d6f3

• simplify DepositPreauth unit tests

  ckeshava

  committed
  379620a

  Copy full SHA for 379620a

• unify the regex used in DIDSet and Credentials

  ckeshava

  committed
  e63b49d

  Copy full SHA for e63b49d

• remove the use of lambda in collecting errors

  ckeshava

  committed
  5425b37

  Copy full SHA for 5425b37

Commits on Nov 1, 2024

• Update xrpl/models/transactions/account_delete.py

  Show description for 3e8b825
  

  ckeshava

  and

  coderabbitai[bot]

  authored
  3e8b825

  Copy full SHA for 3e8b825

• Use variables instead of magic numbers, credential length checks

  ckeshava

  committed
  4106236

  Copy full SHA for 4106236

• remove magic number in credential_delete txn model

  ckeshava

  committed
  6e42798

  Copy full SHA for 6e42798

• use filter construct for deposit_preauth validity check

  ckeshava

  committed
  0719107

  Copy full SHA for 0719107

• remove doc-strings alluding to de-duplication

  ckeshava

  committed
  f1d2b4e

  Copy full SHA for f1d2b4e

• refactor credential_ids check into utils file

  ckeshava

  committed
  bf5114a

  Copy full SHA for bf5114a

Commits on Nov 4, 2024

• Update xrpl/models/transactions/escrow_finish.py

  Show description for 6d8f1be
  

  ckeshava

  and

  coderabbitai[bot]

  authored
  6d8f1be

  Copy full SHA for 6d8f1be

• address PR comments from Mayukha

  ckeshava

  committed
  8e496e1

  Copy full SHA for 8e496e1

• Update tests/integration/transactions/test_credential.py

  Show description for 5656080
  

  ckeshava

  and

  mvadari

  authored
  5656080

  Copy full SHA for 5656080

• Update xrpl/models/utils.py

  Show description for b43aa12
  

  ckeshava

  and

  mvadari

  authored
  b43aa12

  Copy full SHA for b43aa12

• Update xrpl/models/transactions/credential_create.py

  Show description for 6392351
  

  ckeshava

  and

  mvadari

  authored
  6392351

  Copy full SHA for 6392351

• Update xrpl/models/transactions/credential_delete.py

  Show description for 4ad028b
  

  ckeshava

  and

  mvadari

  authored
  4ad028b

  Copy full SHA for 4ad028b

• Update xrpl/models/transactions/deposit_preauth.py

  Show description for 1f25b01
  

  ckeshava

  and

  coderabbitai[bot]

  authored
  1f25b01

  Copy full SHA for 1f25b01

• Merge branch 'main' into cred

  ckeshava

  authored
  a870f2d

  Copy full SHA for a870f2d

Commits on Nov 7, 2024

• address PR comments; check for duplicates in the credential list

  ckeshava

  committed
  a6ac0f4

  Copy full SHA for a6ac0f4

• Update xrpl/models/transactions/credential_create.py

  Show description for 111e12a
  

  ckeshava

  and

  mvadari

  authored
  111e12a

  Copy full SHA for 111e12a

• Update xrpl/models/transactions/credential_delete.py

  Show description for 8593111
  

  ckeshava

  and

  mvadari

  authored
  8593111

  Copy full SHA for 8593111

• Update xrpl/models/transactions/credential_create.py

  Show description for 7fa47e1
  

  ckeshava

  and

  mvadari

  authored
  7fa47e1

  Copy full SHA for 7fa47e1

• address PR comments

  ckeshava

  committed
  3d66a36

  Copy full SHA for 3d66a36

Commits on Nov 8, 2024

• address PR comments

  ckeshava

  committed
  2d86ea2

  Copy full SHA for 2d86ea2

Commits on Nov 9, 2024

• update definitions.json to match rippled develop branch

  ckeshava

  committed
  f58dc2c

  Copy full SHA for f58dc2c

• use short-circuit in an if-condition

  ckeshava

  committed
  0f7f745

  Copy full SHA for 0f7f745

Commits on Nov 12, 2024

• [WIP] Fix CICD integration tests

  ckeshava

  committed
  b02f902

  Copy full SHA for b02f902

• Merge branch 'main' into cred

  ckeshava

  authored
  b70ac84

  Copy full SHA for b70ac84

• CI/CD Fix: Update docker-stop command

  ckeshava

  committed
  7f79596

  Copy full SHA for 7f79596

• LedgerEntry RPC: Introduce Credential functionality

  ckeshava

  committed
  3814a94

  Copy full SHA for 3814a94

• Update Contributing guidelines

  ckeshava

  committed
  c721a87

  Copy full SHA for c721a87

• fix black linter errors

  ckeshava

  committed
  c76b755

  Copy full SHA for c76b755

• fix mypy errors

  ckeshava

  committed
  9b7d17c

  Copy full SHA for 9b7d17c

• re-introduce docker health checks with server_info RPC

  ckeshava

  committed
  5068266

  Copy full SHA for 5068266

Commits on Nov 15, 2024

• remove extraneous comments

  ckeshava

  committed
  c7a6e2e

  Copy full SHA for c7a6e2e

• [WIP] use single docker run command

  ckeshava

  committed
  344bb49

  Copy full SHA for 344bb49

• [WIP] Revert some changes to the CICD integration tests

  Show description for ee01fc9
  ckeshava

  committed
  ee01fc9

  Copy full SHA for ee01fc9

• [refactor] address Ashray PR suggestion

  ckeshava

  committed
  09b7d18

  Copy full SHA for 09b7d18

• update release notes in CHANGELOG

  ckeshava

  committed
  87d2af7

  Copy full SHA for 87d2af7

Commits on Dec 16, 2024

• Update CHANGELOG.md

  Show description for 084bc04
  

  ckeshava

  and

  mvadari

  authored
  084bc04

  Copy full SHA for 084bc04

• Update xrpl/models/transactions/deposit_preauth.py

  Show description for 5828d8e
  

  ckeshava

  and

  mvadari

  authored
  5828d8e

  Copy full SHA for 5828d8e

• address PR comments from @mvadari

  ckeshava

  committed
  c27ab41

  Copy full SHA for c27ab41

Commits on Dec 17, 2024

• Update .ci-config/rippled.cfg

  Show description for 1195417
  

  ckeshava

  and

  khancode

  authored
  1195417

  Copy full SHA for 1195417

• Update xrpl/models/utils.py

  Show description for 1a5fc8b
  

  ckeshava

  and

  khancode

  authored
  1a5fc8b

  Copy full SHA for 1a5fc8b

• Update tests/unit/models/transactions/test_credential_create.py

  Show description for 7d1781a
  

  ckeshava

  and

  khancode

  authored
  7d1781a

  Copy full SHA for 7d1781a

• Update tests/unit/models/transactions/test_credential_accept.py

  Show description for ae55a83
  

  ckeshava

  and

  khancode

  authored
  ae55a83

  Copy full SHA for ae55a83

• Update xrpl/models/utils.py

  Show description for bc71c4c
  

  ckeshava

  and

  khancode

  authored
  bc71c4c

  Copy full SHA for bc71c4c

• Update xrpl/models/utils.py

  Show description for c1adc90
  

  ckeshava

  and

  khancode

  authored
  c1adc90

  Copy full SHA for c1adc90

• Update tests/unit/models/transactions/test_credential_delete.py

  Show description for cf6e618
  

  ckeshava

  and

  khancode

  authored
  cf6e618

  Copy full SHA for cf6e618

• Update tests/unit/models/transactions/test_credential_create.py

  Show description for a6d4f1e
  

  ckeshava

  and

  khancode

  authored
  a6d4f1e

  Copy full SHA for a6d4f1e

• Update tests/unit/models/transactions/test_payment.py

  Show description for cbfb27b
  

  ckeshava

  and

  khancode

  authored
  cbfb27b

  Copy full SHA for cbfb27b

• Update xrpl/models/requests/deposit_authorized.py

  Show description for ed6f6ef
  

  ckeshava

  and

  khancode

  authored
  ed6f6ef

  Copy full SHA for ed6f6ef

• Update tests/unit/models/transactions/test_credential_delete.py

  Show description for 36e2fd6
  

  ckeshava

  and

  khancode

  authored
  36e2fd6

  Copy full SHA for 36e2fd6

• Update xrpl/models/utils.py

  Show description for a039075
  

  ckeshava

  and

  khancode

  authored
  a039075

  Copy full SHA for a039075

• Update xrpl/models/utils.py

  Show description for eb4e176
  

  ckeshava

  and

  khancode

  authored
  eb4e176

  Copy full SHA for eb4e176

• Update xrpl/models/utils.py

  Show description for 7bf9a37
  

  ckeshava

  and

  khancode

  authored
  7bf9a37

  Copy full SHA for 7bf9a37

• Update tests/unit/models/transactions/test_credential_create.py

  Show description for 657af63
  

  ckeshava

  and

  khancode

  authored
  657af63

  Copy full SHA for 657af63

• Update tests/unit/models/transactions/test_credential_create.py

  Show description for 5669d4b
  

  ckeshava

  and

  khancode

  authored
  5669d4b

  Copy full SHA for 5669d4b

• Update tests/unit/models/transactions/test_credential_delete.py

  Show description for 63336b3
  

  ckeshava

  and

  khancode

  authored
  63336b3

  Copy full SHA for 63336b3

• shorten variable names _ACCOUNT_ISSUER

  ckeshava

  committed
  54d894d

  Copy full SHA for 54d894d

• use SHA512Half values for Credential IDs

  ckeshava

  committed
  d754702

  Copy full SHA for d754702

• include multiple credential_ids in PayChanClaim unit tests

  ckeshava

  committed
  397d104

  Copy full SHA for 397d104

• Apply suggestions from code review

  Show description for 1093164
  

  3 peopleauthored
  1093164

  Copy full SHA for 1093164

• address PR comments: refactor _get_errors() method

  ckeshava

  committed
  46861f4

  Copy full SHA for 46861f4

• rectify all unit-test error messages

  ckeshava

  committed
  2593446

  Copy full SHA for 2593446

• Merge branch 'main' into cred

  ckeshava

  authored
  98e0f79

  Copy full SHA for 98e0f79

• rewrite DepositPreauth unit test to use Credential object

  ckeshava

  committed
  70f9301

  Copy full SHA for 70f9301

• pacify the linter

  ckeshava

  committed
  14893ee

  Copy full SHA for 14893ee

Commits on Dec 20, 2024

• Update xrpl/models/transactions/credential_accept.py

  Show description for 24dcb32
  

  ckeshava

  and

  khancode

  authored
  24dcb32

  Copy full SHA for 24dcb32

• Update xrpl/models/transactions/deposit_preauth.py

  Show description for 383a325
  

  ckeshava

  and

  khancode

  authored
  383a325

  Copy full SHA for 383a325

• Update xrpl/models/transactions/credential_delete.py

  Show description for 42e8e71
  

  ckeshava

  and

  khancode

  authored
  42e8e71

  Copy full SHA for 42e8e71

• Update xrpl/models/transactions/credential_create.py

  Show description for e168dcb
  

  ckeshava

  and

  khancode

  authored
  e168dcb

  Copy full SHA for e168dcb

• addressed Omar's comments

  ckeshava

  committed
  387f72b

  Copy full SHA for 387f72b

• Update xrpl/models/transactions/credential_create.py

  Show description for 8e209a1
  

  ckeshava

  and

  khancode

  authored
  8e209a1

  Copy full SHA for 8e209a1

• Update xrpl/models/transactions/credential_create.py

  Show description for 8a93ed7
  

  ckeshava

  and

  khancode

  authored
  8a93ed7

  Copy full SHA for 8a93ed7

• pacify the linter

  ckeshava

  committed
  a059003

  Copy full SHA for a059003

• Merge branch 'main' into cred

  ckeshava

  authored
  d823911

  Copy full SHA for d823911

Commits on Dec 21, 2024

• add recent amendments in rippled

  ckeshava

  committed
  aeabe63

  Copy full SHA for aeabe63

• Update .ci-config/rippled.cfg

  Show description for 26e1b13
  

  ckeshava

  and

  mvadari

  authored
  26e1b13

  Copy full SHA for 26e1b13

• Update CHANGELOG.md

  Show description for 1e09926
  

  ckeshava

  and

  mvadari

  authored
  1e09926

  Copy full SHA for 1e09926

• include None check in validate_creds method

  ckeshava

  committed
  cd7f860

  Copy full SHA for cd7f860