Remove unused wires #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olof Kindgren <[email protected]>
|
Hi, There are more of these. Just sending a first PR to see if this is how you want it fixed |
Your changement will cause W287b Warning in spyglass lint rule. |
|
Hi, I don't have access to Spyglass and have no idea what Warning W287b is, so you will need to explain what it means or let me know if you prefer another fix. The root issue is that the code is referring to a wire that isn't declared anywhere and I'm very surprised if Spyglass doesn't warn about that. `default_nettype none would had made it an error |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Olof Kindgren [email protected]