Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FXV1: Fix Import Quorum #235

Merged
merged 2 commits into from
Dec 14, 2023
Merged

FXV1: Fix Import Quorum #235

merged 2 commits into from
Dec 14, 2023

Conversation

dangell7
Copy link
Collaborator

@dangell7 dangell7 commented Dec 11, 2023 •
edited
Loading

High Level Overview of Change

Fixes the import quorum bug.

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@dangell7 dangell7 closed this Dec 11, 2023
@dangell7 dangell7 reopened this Dec 11, 2023
@RichardAH RichardAH merged commit 6cb07b0 into fixXahauV1 Dec 14, 2023
RichardAH added a commit that referenced this pull request Dec 21, 2023
@dangell7 @RichardAH
Amendment: Fix Xahau v1 (#231)
475b6f7 
* FXV1: Meta Amount (#225)

* FXV1: Optional Offer Sequence (#224)

* FXV1: Patch Hooks OwnerDir (#236)

* FXV1:  Fix `Import` Quorum (#235)

* FXV1: Namespace Limit (#220)

* FXV1: allow duplicate entries in genesis mint transactor (#239)

* FXV1: Fix URIToken (#243)

* lite fixes for tsh issues (#244)

Co-authored-by: RichardAH <[email protected]>
@dangell7 dangell7 deleted the fxv1-import branch January 8, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dangell7 @RichardAH