-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub Actions workflow for JSHooks testing source #449
base: jshooks
Are you sure you want to change the base?
Conversation
- Create a new GitHub Actions workflow for testing JSHooks sources - Update script to generate SetJSHook_wasm.h
- name: Install dependencies | ||
run: | | ||
sudo apt-get update | ||
sudo apt-get install -y build-essential clang-format bc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should pin a specific version of clang-format in some environment variable that be easily changed.
I noticed the other day that clang-format@19 would not work for some files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that clang-format-10 is not provided in ubuntu-latest (ubuntu 22.04).
We can install clang-format-10 in ubuntu 20.04, but errors will occur around qjsc.
At the moment, there is no effect on SetJSHook_wasm.h, so I will leave it as it is.
If you could fix it, I would be very grateful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started working on extracting an action
in #450
I'll make a PR to this once that's sorted we can just use that
src/test/app/build_test_jshooks.sh
Outdated
# | ||
# - clang-format: | ||
# Ubuntu: $sudo apt-get install clang-format | ||
# macOS: $brew install clang-format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brew install r-lib/taps/clang-format@10
To match the CI clang-format I had to use that. 19 wasn't working in every case.
related to:
https://github.com/Xahau/xahaud/pull/449/files#r1972938606
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the ggrep -> grep and gsed -> sed changes, this looks good to me. I think I'd rather leave the macos defaults as they are for other scripts?
We better double check me re: cf 10
I may be confused
…On Thu, 27 Feb 2025, 6:20 pm tequ, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/workflows/js_hooks_test.yml
<#449 (comment)>:
> +concurrency:
+ group: ${{ github.workflow }}
+ cancel-in-progress: false
+
+jobs:
+ jshooks-test-sources:
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Checkout
+ uses: ***@***.***
+
+ - name: Install dependencies
+ run: |
+ sudo apt-get update
+ sudo apt-get install -y build-essential clang-format bc
It seems that clang-format-10 is not provided in ubuntu-latest (ubuntu
22.04).
We can install clang-format-10 in ubuntu 20.04, but errors will occur
around qjsc.
At the moment, there is no effect on SetJSHook_wasm.h, so I will leave it
as it is.
If you could fix it, I would be very grateful.
—
Reply to this email directly, view it on GitHub
<#449 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEAHGY6GNJ2PHQ7T5PF7X32R3YHTAVCNFSM6AAAAABX2PZO2KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMNBXGQ2TAMBRGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
High Level Overview of Change
Context of Change
Type of Change
.gitignore
, formatting, dropping support for older tooling)API Impact
libxrpl
change (any change that may affectlibxrpl
or dependents oflibxrpl
)