Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added mm_einsum #515
base: develop
Are you sure you want to change the base?
added mm_einsum #515
Changes from 2 commits
ae6861e
971f7fc
01b56e7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 18 in mrmustard/physics/mm_einsum.py
Codecov / codecov/patch
mrmustard/physics/mm_einsum.py#L16-L18
Check warning on line 22 in mrmustard/physics/mm_einsum.py
Codecov / codecov/patch
mrmustard/physics/mm_einsum.py#L21-L22
Check warning on line 29 in mrmustard/physics/mm_einsum.py
Codecov / codecov/patch
mrmustard/physics/mm_einsum.py#L29
Check warning on line 36 in mrmustard/physics/mm_einsum.py
Codecov / codecov/patch
mrmustard/physics/mm_einsum.py#L36
Check warning on line 39 in mrmustard/physics/mm_einsum.py
Codecov / codecov/patch
mrmustard/physics/mm_einsum.py#L39
Check warning on line 73 in mrmustard/physics/mm_einsum.py
Codecov / codecov/patch
mrmustard/physics/mm_einsum.py#L71-L73
Check warning on line 78 in mrmustard/physics/mm_einsum.py
Codecov / codecov/patch
mrmustard/physics/mm_einsum.py#L76-L78
Check warning on line 81 in mrmustard/physics/mm_einsum.py
Codecov / codecov/patch
mrmustard/physics/mm_einsum.py#L81
Check warning on line 86 in mrmustard/physics/mm_einsum.py
Codecov / codecov/patch
mrmustard/physics/mm_einsum.py#L85-L86
Check warning on line 88 in mrmustard/physics/mm_einsum.py
Codecov / codecov/patch
mrmustard/physics/mm_einsum.py#L88
Check warning on line 91 in mrmustard/physics/mm_einsum.py
Codecov / codecov/patch
mrmustard/physics/mm_einsum.py#L91
Check warning on line 94 in mrmustard/physics/mm_einsum.py
Codecov / codecov/patch
mrmustard/physics/mm_einsum.py#L94
Check warning on line 97 in mrmustard/physics/mm_einsum.py
Codecov / codecov/patch
mrmustard/physics/mm_einsum.py#L96-L97
Check warning on line 100 in mrmustard/physics/mm_einsum.py
Codecov / codecov/patch
mrmustard/physics/mm_einsum.py#L100
Check warning on line 114 in mrmustard/physics/mm_einsum.py
Codecov / codecov/patch
mrmustard/physics/mm_einsum.py#L113-L114
Check warning on line 122 in mrmustard/physics/mm_einsum.py
Codecov / codecov/patch
mrmustard/physics/mm_einsum.py#L116-L122
Check warning on line 125 in mrmustard/physics/mm_einsum.py
Codecov / codecov/patch
mrmustard/physics/mm_einsum.py#L125
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the
optimal
function, consider adding a timeout mechanism or a maximum iteration limit to prevent potential infinite loops or excessive runtime for very large input sets. This would improve the robustness of the function. [important]Check warning on line 164 in mrmustard/physics/mm_einsum.py
Codecov / codecov/patch
mrmustard/physics/mm_einsum.py#L162-L164
Check warning on line 166 in mrmustard/physics/mm_einsum.py
Codecov / codecov/patch
mrmustard/physics/mm_einsum.py#L166
Check warning on line 173 in mrmustard/physics/mm_einsum.py
Codecov / codecov/patch
mrmustard/physics/mm_einsum.py#L170-L173
Check warning on line 178 in mrmustard/physics/mm_einsum.py
Codecov / codecov/patch
mrmustard/physics/mm_einsum.py#L176-L178
Check warning on line 182 in mrmustard/physics/mm_einsum.py
Codecov / codecov/patch
mrmustard/physics/mm_einsum.py#L181-L182
Check warning on line 188 in mrmustard/physics/mm_einsum.py
Codecov / codecov/patch
mrmustard/physics/mm_einsum.py#L184-L188
Check warning on line 195 in mrmustard/physics/mm_einsum.py
Codecov / codecov/patch
mrmustard/physics/mm_einsum.py#L193-L195
Check warning on line 198 in mrmustard/physics/mm_einsum.py
Codecov / codecov/patch
mrmustard/physics/mm_einsum.py#L198
Check warning on line 205 in mrmustard/physics/mm_einsum.py
Codecov / codecov/patch
mrmustard/physics/mm_einsum.py#L205
Check warning on line 211 in mrmustard/physics/mm_einsum.py
Codecov / codecov/patch
mrmustard/physics/mm_einsum.py#L209-L211