This repository has been archived by the owner on Jun 27, 2020. It is now read-only.
Fix handling of multiple completion scopes #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the YAML front matter contains no "completion-scope", the expression `[front_matter["completion-scope"]]` evaluates to `[nil]`, which is truthy, so the rest of the chain is not evaluated and the snippet is assigned `completion_scopes` of `[nil]`. As it happens, `[nil]` is serialised as `<array><data>BAgw</data></array>`. When a code snippet containing that "completion scope" is present, Xcode crashes as soon as I try to enter any text in a place where a snippet might be admissible. This change replaces the chain of `||` operators with a `case` block. This leads to some ugly repetition in the resulting code, but at least it doesn't crash Xcode. ;-)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the YAML front matter contains no "completion-scope", the
expression
[front_matter["completion-scope"]]evaluates to[nil],which is truthy, so the rest of the chain is not evaluated and the
snippet is assigned
completion_scopesof[nil].As it happens,
[nil]is serialised as<array><data>BAgw</data></array>.When a code snippet containing that "completion scope" is present,
Xcode crashes as soon as I try to enter any text in a place where
a snippet might be admissible.
This change replaces the chain of
||operators with acaseblock. This leads to some ugly repetition in the resulting code,
but at least it doesn't crash Xcode. ;-)