Decompiled lib func_us_801BB8DC/func_psp_09255D78
#2253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gamezter
reviewed
Feb 24, 2025
src/st/lib_psp/unk_1D9E8.c
Outdated
| if (g_CurrentEntity->ext.lesserDemon.unkB0 % 2) { | ||
| g_CurrentEntity->palette = g_CurrentEntity->ext.lesserDemon.unkB2; | ||
| } else { | ||
| g_CurrentEntity->palette = PAL_DRA(0x819F); |
There was a problem hiding this comment.
I think this is actually PAL_OVL(0x19F)
There was a problem hiding this comment.
They both match locally, what's the difference between the two? Aside from the obvious | 0x8000.
There was a problem hiding this comment.
I think OVL signifies that it 'belongs' to the overlay. I just know that there are currently no PAL_DRA(0x8...) in the project
There was a problem hiding this comment.
Whoops sorry, that's my bad, wrote the wrong macro on my earlier comment
sozud
approved these changes
Feb 24, 2025
sozud
reviewed
Feb 24, 2025
src/st/lib/e_lesser_demon.c
Outdated
| if (g_CurrentEntity->ext.lesserDemon.unkB0 % 2) { | ||
| g_CurrentEntity->palette = g_CurrentEntity->ext.lesserDemon.unkB2; | ||
| } else { | ||
| g_CurrentEntity->palette = PAL_OVL(0x819F); |
There was a problem hiding this comment.
PAL_OVL is already | 0x8000 so you want PAL_OVL(0x19F);
There was a problem hiding this comment.
Whoops, I missed that in gamezter's comment. It makes a bit more sense to me now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PSX: https://www.decomp.me/scratch/oWf8p
PSP: https://www.decomp.me/scratch/BzLiq