Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Non-Function Labels in dups #2262

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

hohle
Copy link
Contributor

@hohle hohle commented Feb 25, 2025

Only consider glabels in .text sections.

By default, a file is treated as if it is a .text segment and lines will only be ignored if a .section directive is used.

Only consider `glabel`s in `.text` sections.

By default, a file is treated as if it is a `.text` segment and lines
will only be ignored if a `.section` directive is used.
@hohle
Copy link
Contributor Author

hohle commented Feb 25, 2025

Updated report: https://gist.github.com/hohle/fdaf4e7d81bf4c2d361befedaa1cb53d

I realized this has a local build with different symbols for bo4. I'll posted a vanilla version later tonight.

Copy link
Owner

@Xeeynamo Xeeynamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. No need for a clean version of BO4.

@Xeeynamo Xeeynamo merged commit 9c93328 into Xeeynamo:master Feb 26, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants