Fix a couple of PSP build warnings #2283
Open
+1
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshSchreuder
commented
Mar 4, 2025
| @@ -56,7 +56,7 @@ static s16 g_SineTable[] = { | |||
| #include "move_entity.h" | |||
| #include "fall_entity.h" | |||
|
|
|||
| #if defined(VERSION_BETA) || STAGE == STAGE_ST0 | |||
| #if defined(VERSION_BETA) || (STAGE == STAGE_ST0 && !defined(VERSION_PSP)) | |||
There was a problem hiding this comment.
This function is stripped on PSP but still goes through the compiler, we can just exclude it.
### mwccpsp.exe Compiler:
# In: src\st\st_common.h
# From: src\st\st0\st_common.c
# -------------------------------
# 61: u8 unkState;
# Warning: ^^^^^^^^
# variable 'unkState' is not initialized before being used
JoshSchreuder
commented
Mar 4, 2025
| @@ -80,8 +80,6 @@ void ProcessEvent(Entity* self, bool resetEvent) { | |||
| } else { | |||
| queue = g_EventQueue; | |||
| while (queue->next != NULL) { | |||
| if (!evt->delay) { | |||
| } | |||
There was a problem hiding this comment.
Not sure why this was added, but doesn't seem needed for a match
### mwccpsp.exe Compiler:
# In: src\servant\process_event.h
# From: src\servant\tt_000\bat.c
# ---------------------------------
# 10: ServantEvent* evt;
# Warning: ^
# variable 'evt' is not initialized before being used
### mwccpsp.exe Compiler:
# In: src\servant\process_event.h
# From: src\servant\tt_000\tmp0ls8s_qu.c
# -----------------------------------------
# 10: ServantEvent* evt;
# Warning: ^
# variable 'evt' is not initialized before being used
sozud
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing major, just a couple of things that were bugging me while working on PSP.