Merge branch 'main' into refactor-alignment

.clang-format

@@ -1,10 +1,9 @@
----
 BasedOnStyle: Google
 Language: Cpp
 AllowShortBlocksOnASingleLine: Never
 AllowShortCaseLabelsOnASingleLine: false
 AllowShortFunctionsOnASingleLine: Inline
-AllowShortIfStatementsOnASingleLine: false
+AllowShortIfStatementsOnASingleLine: Never
 AllowShortLoopsOnASingleLine: false
 PointerAlignment: Left
 ColumnLimit: 80
@@ -28,4 +27,3 @@ IncludeCategories:
   - Regex:    '^<.*>'
     Priority: 3
   # all headers not explicitly listed will be assigned to the last group
----

.github/issue_template.md

@@ -12,7 +12,7 @@ FOR YOUR INFORMATION AND MUST BE REMOVED BEFORE SUBMITTING THE ISSUE.
 
 - [ ] If the issue reports a bug:
 
-    - [ ] Please suggest whether this bug is critical / a blocker. One of the 
+    - [ ] Please suggest whether this bug is critical / a blocker. One of the
           maintainers will assign a corresponding labels.
     - [ ] Does the description contain all necessary information to reproduce
-          the error?
+          the error?

.github/pull_request_template.md

@@ -38,4 +38,4 @@ REQUEST.
 
 - If you push updates, and you know they will be superceded later on, consider adding
   `[skip ci]` in the commit message. This will instruct the CI system not to run any
-  jobs on this commit.
+  jobs on this commit.

.github/wip.yml

@@ -1,6 +1,5 @@
-- locations: 
+- locations:
     - title
     - label_name
   terms:
     - WIP
-

.github/workflows/analysis.yml

@@ -98,6 +98,7 @@ jobs:
           --preset=github-ci
           -DCMAKE_BUILD_TYPE=RelWithDebInfo
           -DCMAKE_CXX_FLAGS="-Werror"
+          -DACTS_BUILD_ODD=OFF
       - name: Measure
         run: cmakeperf collect build/compile_commands.json -o perf.csv
       - name: Results

.github/workflows/backport.yml

@@ -6,7 +6,7 @@ on:
       - closed
       - labeled
 
-concurrency: 
+concurrency:
   group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
   cancel-in-progress: true
 

.github/workflows/checks.yml

@@ -13,31 +13,30 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  format:
-    runs-on: ubuntu-latest
-    container: ghcr.io/acts-project/format14:51
-    steps:
-      - uses: actions/checkout@v4
-      - name: Check
-        run: >
-          git config --global safe.directory "$GITHUB_WORKSPACE"
-          && CI/check_format .
-      - uses: actions/upload-artifact@v4
-        if: failure()
-        with:
-          name: changed
-          path: changed
-  format-py:
+  lint:
     runs-on: ubuntu-latest
+    env:
+      PRE_COMMIT_HOME: '/tmp/pre-commit'
+
     steps:
-      - uses: actions/checkout@v4
+      - name: Checkout
+        uses: actions/checkout@v4
+
       - uses: actions/setup-python@v5
         with:
           python-version: '3.12'
-      - name: Install black
-        run: pip install black[jupyter]==24.4.2
-      - name: Run black format check
-        run: black --check . --extend-exclude ".*thirdparty.*"
+
+      - uses: actions/cache@v4
+        with:
+          path: |
+            ${{ env.PRE_COMMIT_HOME }}
+          key: ${{ runner.os }}-${{ hashFiles('.pre-commit-config.yaml') }}
+
+      - name: Install pre-commit
+        run: pip install pre-commit
+
+      - name: Run pre-commit
+        run: pre-commit run --all-files --show-diff-on-failure
 
   license:
     runs-on: ubuntu-latest
@@ -67,16 +66,6 @@ jobs:
       - name: Check
         run: >
           CI/check_pragma_once.sh
-  end_of_line:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-python@v5
-        with:
-          python-version: '3.12'
-      - name: Check
-        run: >
-          CI/check_end_of_file.py . --exclude "thirdparty/*" --reject-multiple-newlines --github
   type_t:
     runs-on: ubuntu-latest
     steps:

.github/workflows/docs.yml

@@ -54,7 +54,7 @@ jobs:
           -b linkcheck
           . _build/html/
 
-          
+
       - uses: actions/upload-artifact@v4
         with:
           name: acts-docs

.github/workflows/release.yml

@@ -1,6 +1,6 @@
 name: Release
 
-on: 
+on:
   push:
     branches:
       - 'releases'

.github/workflows/report.yml

@@ -67,7 +67,7 @@ jobs:
               return false;
             }
 
-            
+
             let number = Number(fs.readFileSync(file, {encoding: 'utf8'}).trim());
             console.log('PR number is '+number);
             core.exportVariable('PR_NUMBER', number)

.merge-sentinel.yml

@@ -9,7 +9,7 @@ rules:
      - "main"
      - "develop/*"
     paths_ignore:
-     - "docs/*" 
+     - "docs/*"
 
     required_checks:
      - Docs / docs
@@ -24,6 +24,6 @@ rules:
      - "main"
      - "develop/*"
     paths:
-     - "docs/*" 
+     - "docs/*"
     required_checks:
      - Docs / docs

.pre-commit-config.yaml

@@ -1,6 +1,6 @@
 repos:
   - repo: https://github.com/pre-commit/mirrors-clang-format
-    rev: 'v14.0.0'
+    rev: 'v18.1.8'
     hooks:
       - id: clang-format
         types_or: [file]

Alignment/README.md

@@ -1,5 +1,5 @@
 # Alignment package
 
 This packages provides tools for detector geometry alignment.
-Currently, the KalmanFitter-based alignment with internal minimization is implemented. 
-In the future, the minimization will be done based on the external minimization package e.g. Millepede. 
+Currently, the KalmanFitter-based alignment with internal minimization is implemented.
+In the future, the minimization will be done based on the external minimization package e.g. Millepede.

CI/README.md

@@ -8,4 +8,4 @@ Since [`poetry`](https://python-poetry.org) supports more robust dependency lock
 
 ```console
 poetry export -f requirements.txt > requirements.txt
-```
+```

CI/codespell_ignore.txt

@@ -21,4 +21,4 @@ ans
 dthe
 dthe
 vart
-pixelx
+pixelx

CI/ctest2junit.xsl

@@ -63,7 +63,7 @@ Extended by providing total Start date, total time, total test stats
 				<property name="ProcessorClockFrequency" value="{$ProcessorClockFrequency}" />
 			</properties>
 			<xsl:apply-templates select="Testing/Test"/>
-			
+
 			<system-out>
 				BuildName: <xsl:value-of select="$BuildName" />
 				BuildStamp: <xsl:value-of select="$BuildStamp" />
@@ -101,7 +101,7 @@ Extended by providing total Start date, total time, total test stats
 				</xsl:if>
 			</xsl:for-each>
 		</xsl:variable>
-		
+
 			<testcase name="{$testcasename}" classname="{$testclassname}" time="{$exectime}">
             <xsl:if test="@Status = 'passed'">
             <system-out><xsl:value-of select="Results/Measurement/Value/text()"/></system-out>
@@ -130,4 +130,3 @@ Extended by providing total Start date, total time, total test stats
     </xsl:template>
 
 </xsl:stylesheet>
-

CI/physmon/default.yml → CI/physmon/config/trackfitting_gsf.yml

@@ -10,4 +10,3 @@ checks:
       threshold: 3
     IntegralCheck:
       threshold: 3
-

CI/physmon/vertexing_config.yml → CI/physmon/config/vertexing_4muon_50vertices.yml

@@ -83,12 +83,12 @@ histograms:
     nbins: 100
     min: 0.999
     max: 1
-  
+
   "trk_weight":
     nbins: 100
     min: -0.01
     max: 1.01
-  
+
   "sumPt2":
     nbins: 100
     min: 0

CI/physmon/vertexing_ttbar_config.yml → CI/physmon/config/vertexing_ttbar_pu200.yml

@@ -83,7 +83,7 @@ histograms:
     nbins: 100
     min: 0.999
     max: 1
-  
+
   "sumPt2":
     nbins: 100
     min: 0