Integration of new deconvolution implementation based on the REVD2 algorithm (Ongoing) #1263

hleblevec · 2025-01-16T14:31:39Z

Integration of the new deconvolution implementation (see https://github.com/Xilinx/finn-hlslib/blob/feature/deconv/deconv.hpp for the HLS part).

Current known issues:

Several failing cppsim testcases, which seem to be linked to padding when P < K-S
rtlsim currently not working, probably due to issues in the templates
Some testcases might fail due to loop timeout value being too small (need to identify if there are still cases where that happens)

…Xilinx-feature/deconv

auphelia · 2025-01-23T14:22:57Z

Thank you for starting with this PR! I wanted to quickly point you to this new template which has an easier setup to use the time out simulation: https://github.com/Xilinx/finn/blob/feature/deconv/src/finn/custom_op/fpgadataflow/templates.py#L63

hleblevec added 13 commits June 26, 2024 10:02

Merge branch 'dev' into feature/deconv

b3bbfe0

update finn-hlslib commit hash

629a65e

deconv test now passing multiple channels

b8501c9

[Deconv] Updating tests and custom HLS node, passing most cppsim tests

c5aa427

[Deconv] Updating tests and custom HLS node, passing most cppsim tests

f7cbd48

[Deconv] Updating tests and custom HLS node, passing most cppsim tests

891a305

Merge branch 'dev' into feature/deconv

dc2a48f

Changing the computation of the timout value to be based on parameters

c157dc0

Increasing the timeout value as it fails some test configurations

cee4e70

Merge branch 'feature/deconv' of https://github.com/Xilinx/finn into …

6a1fc41

…Xilinx-feature/deconv

Merge branch 'Xilinx-feature/deconv' into feature/deconv

837019a

Updating HLSLIB commit hash to the most recent

248848e

Setting test parameters to failing case

91e8116

Provide feedback