Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LLVM Project Tests Workflow on Linux (#122221) #275

Merged
merged 4 commits into from
Jan 17, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/amd-aie-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@ jobs:
projects: clang;lld
cache-key: amd-aie
extra_cmake_args: '-DLLVM_USE_LINKER=gold -C clang/cmake/caches/Peano-AIE.cmake'
os_list: '["ubuntu-latest"]'
os_list: '["ubuntu-22.04"]'
4 changes: 2 additions & 2 deletions .github/workflows/amd-upstream-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
projects: clang
cache-key: amd-upstream
extra_cmake_args: '-DLLVM_USE_LINKER=gold -DLLVM_TARGETS_TO_BUILD="X86;ARM;AArch64;AMDGPU" -DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD=""'
os_list: '["ubuntu-latest", "windows-2019"]'
os_list: '["ubuntu-22.04", "windows-2019"]'

check_lld:
if: github.repository_owner == 'Xilinx'
Expand All @@ -41,5 +41,5 @@ jobs:
projects: lld
cache-key: amd-upstream
extra_cmake_args: '-DLLVM_USE_LINKER=gold -DLLVM_TARGETS_TO_BUILD="X86;ARM;AArch64;AMDGPU" -DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD=""'
os_list: '["ubuntu-latest", "windows-2019"]'
os_list: '["ubuntu-22.04", "windows-2019"]'

2 changes: 1 addition & 1 deletion .github/workflows/libclang-python-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,5 @@ jobs:
projects: clang
# There is an issue running on "windows-2019".
# See https://github.com/llvm/llvm-project/issues/76601#issuecomment-1873049082.
os_list: '["ubuntu-latest"]'
os_list: '["ubuntu-22.04"]'
python_version: ${{ matrix.python-version }}
12 changes: 9 additions & 3 deletions .github/workflows/llvm-project-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,12 @@ on:
type: string
# Use windows-2019 due to:
# https://developercommunity.visualstudio.com/t/Prev-Issue---with-__assume-isnan-/1597317
default: '["ubuntu-latest", "windows-2019", "macOS-13"]'
# Use ubuntu-22.04 rather than ubuntu-latest to match the ubuntu
# version in the CI container. Without this, setup-python tries
# to install a python version linked against a newer version of glibc.
# TODO(boomanaiden154): Bump the Ubuntu version once the version in the
# container is bumped.
default: '["ubuntu-22.04", "windows-2019", "macOS-13"]'

python_version:
required: false
Expand All @@ -67,7 +72,7 @@ jobs:
name: Lit Tests
runs-on: ${{ matrix.os }}
container:
image: ${{(startsWith(matrix.os, 'ubuntu') && 'ghcr.io/llvm/ci-ubuntu-22.04:1734381129') || null}}
image: ${{(startsWith(matrix.os, 'ubuntu') && 'ghcr.io/llvm/ci-ubuntu-22.04:latest') || null}}
volumes:
- /mnt/:/mnt/
strategy:
Expand Down Expand Up @@ -120,7 +125,8 @@ jobs:
run: |
if [ "${{ runner.os }}" == "Linux" ]; then
builddir="/mnt/build/"
mkdir -p $builddir
sudo mkdir -p $builddir
sudo chown gha $builddir
extra_cmake_args="-DCMAKE_CXX_COMPILER=clang++ -DCMAKE_C_COMPILER=clang"
else
builddir="$(pwd)"/build
Expand Down
Loading