Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIE2P] End-to-End support of fifo store intrinsics #308

Merged
merged 3 commits into from
Jan 29, 2025
Merged

[AIE2P] End-to-End support of fifo store intrinsics #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7218242
[AIE2P] Add fifo store intrinsics - IR lowering
khallouh Jan 23, 2025
e9cd6dd
[AIE2P] Support Fifo Stores in Register Bank Selection
khallouh Jan 23, 2025
a33eb0a
[AIE2P] Select fifo store intrinsics
khallouh Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion clang/include/clang/Basic/BuiltinsAIE2P.def
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
// (c) Copyright 2024 Advanced Micro Devices, Inc. or its affiliates
// (c) Copyright 2024-2025 Advanced Micro Devices, Inc. or its affiliates
//
//===----------------------------------------------------------------------===//
//
Expand Down Expand Up @@ -323,3 +323,15 @@ BUILTIN(__builtin_aie2p_divstep, "vUi&Ui&Ui", "nc")

// SHUFFLE
BUILTIN(__builtin_aie2p_vshuffle_576_bfp16, "vV64cV8cV64cV8ciV64c&V8c&", "nc")
// Unaligned and bfp16 stores
BUILTIN(__builtin_aie2p_fifo_st_push_576_bfp16, "vi*&V64cV8cV32i&i&", "nc")
BUILTIN(__builtin_aie2p_fifo_st_push_512_bfp16, "vi*&V16iV32i&i&", "nc")
BUILTIN(__builtin_aie2p_fifo_st_push_544_bfp16, "vi*&V64cV8cV32i&i&", "nc")
BUILTIN(__builtin_aie2p_fifo_st_flush, "vi*&V32i&i&", "nc")
BUILTIN(__builtin_aie2p_fifo_st_flush_1d_byte, "vi*&V32i&i&i", "nc")
BUILTIN(__builtin_aie2p_fifo_st_flush_2d_byte, "vi*&V32i&i&iii&i", "nc")
BUILTIN(__builtin_aie2p_fifo_st_flush_3d_byte, "vi*&V32i&i&iii&iii&i", "nc")
BUILTIN(__builtin_aie2p_fifo_st_flush_conv, "vi*&V32i&i&", "nc")
BUILTIN(__builtin_aie2p_fifo_st_flush_conv_1d_byte, "vi*&V32i&i&i", "nc")
BUILTIN(__builtin_aie2p_fifo_st_flush_conv_2d_byte, "vi*&V32i&i&iii&i", "nc")
BUILTIN(__builtin_aie2p_fifo_st_flush_conv_3d_byte, "vi*&V32i&i&iii&iii&i", "nc")
153 changes: 151 additions & 2 deletions clang/lib/CodeGen/CGBuiltin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
// Modifications (c) Copyright 2023-2024 Advanced Micro Devices, Inc. or its
// Modifications (c) Copyright 2023-2025 Advanced Micro Devices, Inc. or its
// affiliates
//
//===----------------------------------------------------------------------===//
Expand Down Expand Up @@ -64,6 +64,7 @@
#include "llvm/IR/MDBuilder.h"
#include "llvm/IR/MatrixBuilder.h"
#include "llvm/Support/ConvertUTF.h"
#include "llvm/Support/ErrorHandling.h"
#include "llvm/Support/MathExtras.h"
#include "llvm/Support/ScopedPrinter.h"
#include "llvm/TargetParser/AArch64TargetParser.h"
Expand Down Expand Up @@ -22056,6 +22057,28 @@ static llvm::Intrinsic::ID getAIE2PIntrinsicFunction(unsigned BuiltinID) {
return Intrinsic::aie2p_v64bfp16ebs8_to_v64bfp16ebs16;
case AIE::BI__builtin_aie2p_vshuffle_576_bfp16:
return Intrinsic::aie2p_vshuffle_576_bfp16;
case AIE::BI__builtin_aie2p_fifo_st_push_512_bfp16:
return Intrinsic::aie2p_fifo_st_push_512_bfp16;
case AIE::BI__builtin_aie2p_fifo_st_push_544_bfp16:
return Intrinsic::aie2p_fifo_st_push_544_bfp16;
case AIE::BI__builtin_aie2p_fifo_st_push_576_bfp16:
return Intrinsic::aie2p_fifo_st_push_576_bfp16;
case AIE::BI__builtin_aie2p_fifo_st_flush:
return Intrinsic::aie2p_fifo_st_flush;
case AIE::BI__builtin_aie2p_fifo_st_flush_conv:
return Intrinsic::aie2p_fifo_st_flush_conv;
case AIE::BI__builtin_aie2p_fifo_st_flush_1d_byte:
return Intrinsic::aie2p_fifo_st_flush_1d;
case AIE::BI__builtin_aie2p_fifo_st_flush_conv_1d_byte:
return Intrinsic::aie2p_fifo_st_flush_1d_conv;
case AIE::BI__builtin_aie2p_fifo_st_flush_2d_byte:
return Intrinsic::aie2p_fifo_st_flush_2d_conv;
case AIE::BI__builtin_aie2p_fifo_st_flush_conv_2d_byte:
return Intrinsic::aie2p_fifo_st_flush_2d;
case AIE::BI__builtin_aie2p_fifo_st_flush_3d_byte:
return Intrinsic::aie2p_fifo_st_flush_3d;
case AIE::BI__builtin_aie2p_fifo_st_flush_conv_3d_byte:
return Intrinsic::aie2p_fifo_st_flush_3d_conv;
default:
break;
}
Expand Down Expand Up @@ -22293,6 +22316,7 @@ Value *CodeGenFunction::EmitAIEBuiltinExpr(unsigned BuiltinID,
Ops.push_back(EmitScalarExpr(E->getArg(E->getNumArgs() - 2)));
Ops.push_back(EmitScalarExpr(E->getArg(E->getNumArgs() - 1)));
}

llvm::Intrinsic::ID IntrinsicID = getAIEIntrinsicFunction(BuiltinID, Arch);
assert(IntrinsicID != Intrinsic::not_intrinsic);
Function *F = CGM.getIntrinsic(IntrinsicID);
Expand Down Expand Up @@ -22331,6 +22355,120 @@ Value *CodeGenFunction::EmitAIEBuiltinExpr(unsigned BuiltinID,
EmitLValue(E->getArg(E->getNumArgs() - 1)).getPointer(*this);
return Builder.CreateDefaultAlignedStore(Exp, ExpAddr);
}
case AIE::BI__builtin_aie2p_fifo_st_push_512_bfp16:
case AIE::BI__builtin_aie2p_fifo_st_push_544_bfp16:
case AIE::BI__builtin_aie2p_fifo_st_push_576_bfp16:
case AIE::BI__builtin_aie2p_fifo_st_flush_conv:
case AIE::BI__builtin_aie2p_fifo_st_flush: {
gbossu marked this conversation as resolved.
Show resolved Hide resolved
SmallVector<Value *, 3> Ops;
for (unsigned I = 0; I < E->getNumArgs(); I++)
Ops.push_back(EmitScalarExpr(E->getArg(I)));

llvm::Intrinsic::ID IntrinsicID = getAIEIntrinsicFunction(BuiltinID, Arch);
assert(IntrinsicID != Intrinsic::not_intrinsic);
Function *F = CGM.getIntrinsic(IntrinsicID);
Value *Val = Builder.CreateCall(F, Ops);

Value *Ptr = Builder.CreateExtractValue(Val, 0);
Value *Fifo = Builder.CreateExtractValue(Val, 1);
Value *Avail = Builder.CreateExtractValue(Val, 2);
Value *PtrAddr = EmitLValue(E->getArg(0)).getPointer(*this);

Value *FifoAddr = nullptr;
Value *AvailAddr = nullptr;
if (BuiltinID == AIE::BI__builtin_aie2p_fifo_st_flush ||
BuiltinID == AIE::BI__builtin_aie2p_fifo_st_flush_conv) {
FifoAddr = EmitLValue(E->getArg(1)).getPointer(*this);
AvailAddr = EmitLValue(E->getArg(2)).getPointer(*this);
} else if (BuiltinID == AIE::BI__builtin_aie2p_fifo_st_push_512_bfp16) {
FifoAddr = EmitLValue(E->getArg(2)).getPointer(*this);
AvailAddr = EmitLValue(E->getArg(3)).getPointer(*this);
} else {
gbossu marked this conversation as resolved.
Show resolved Hide resolved
assert(BuiltinID == AIE::BI__builtin_aie2p_fifo_st_push_576_bfp16 ||
BuiltinID == AIE::BI__builtin_aie2p_fifo_st_push_544_bfp16 &&
"Unexpected BuiltinID");
FifoAddr = EmitLValue(E->getArg(3)).getPointer(*this);
AvailAddr = EmitLValue(E->getArg(4)).getPointer(*this);
}

Builder.CreateDefaultAlignedStore(Fifo, FifoAddr);
Builder.CreateDefaultAlignedStore(Avail, AvailAddr);
return Builder.CreateDefaultAlignedStore(Ptr, PtrAddr);
}
case AIE::BI__builtin_aie2p_fifo_st_flush_conv_1d_byte:
case AIE::BI__builtin_aie2p_fifo_st_flush_1d_byte:
case AIE::BI__builtin_aie2p_fifo_st_flush_conv_2d_byte:
case AIE::BI__builtin_aie2p_fifo_st_flush_2d_byte:
case AIE::BI__builtin_aie2p_fifo_st_flush_conv_3d_byte:
case AIE::BI__builtin_aie2p_fifo_st_flush_3d_byte: {
SmallVector<Value *, 3> Ops;
unsigned NumAddrIncs = 0;
switch (BuiltinID) {
case AIE::BI__builtin_aie2p_fifo_st_flush_1d_byte:
case AIE::BI__builtin_aie2p_fifo_st_flush_conv_1d_byte:
NumAddrIncs = 1;
break;
case AIE::BI__builtin_aie2p_fifo_st_flush_2d_byte:
case AIE::BI__builtin_aie2p_fifo_st_flush_conv_2d_byte:
NumAddrIncs = 4;
break;
case AIE::BI__builtin_aie2p_fifo_st_flush_3d_byte:
case AIE::BI__builtin_aie2p_fifo_st_flush_conv_3d_byte:
NumAddrIncs = 7;
break;
default:
llvm_unreachable("Unexpected BuiltinID");
}
khallouh marked this conversation as resolved.
Show resolved Hide resolved

for (unsigned I = 0; I < E->getNumArgs() - NumAddrIncs; I++)
Ops.push_back(EmitScalarExpr(E->getArg(I)));

for (unsigned i = E->getNumArgs() - NumAddrIncs, e = E->getNumArgs();
i != e; i++) {
Ops.push_back(
Builder.CreateTrunc(EmitScalarExpr(E->getArg(i)),
llvm::Type::getInt20Ty(getLLVMContext())));
}
llvm::Intrinsic::ID IntrinsicID = getAIEIntrinsicFunction(BuiltinID, Arch);
assert(IntrinsicID != Intrinsic::not_intrinsic);
Function *F = CGM.getIntrinsic(IntrinsicID);
Value *Val = Builder.CreateCall(F, Ops);

Value *Ptr = Builder.CreateExtractValue(Val, 0);
Value *Fifo = Builder.CreateExtractValue(Val, 1);
Value *Avail = Builder.CreateExtractValue(Val, 2);
Value *PtrAddr = EmitLValue(E->getArg(0)).getPointer(*this);
Value *FifoAddr = EmitLValue(E->getArg(1)).getPointer(*this);
Value *AvailAddr = EmitLValue(E->getArg(2)).getPointer(*this);

if (BuiltinID == AIE::BI__builtin_aie2p_fifo_st_flush_2d_byte ||
BuiltinID == AIE::BI__builtin_aie2p_fifo_st_flush_conv_2d_byte) {
Value *Count1 =
Builder.CreateZExt(Builder.CreateExtractValue(Val, 3),
llvm::Type::getInt32Ty(getLLVMContext()));
Value *Count1Addr = EmitLValue(E->getArg(5)).getPointer(*this);
Builder.CreateDefaultAlignedStore(Count1, Count1Addr);
} else if (BuiltinID == AIE::BI__builtin_aie2p_fifo_st_flush_3d_byte ||
BuiltinID == AIE::BI__builtin_aie2p_fifo_st_flush_conv_3d_byte) {
Value *Count1 =
Builder.CreateZExt(Builder.CreateExtractValue(Val, 3),
llvm::Type::getInt32Ty(getLLVMContext()));
Value *Count1Addr =
EmitLValue(E->getArg(E->getNumArgs() - 5)).getPointer(*this);
Value *Count2 =
Builder.CreateZExt(Builder.CreateExtractValue(Val, 4),
llvm::Type::getInt32Ty(getLLVMContext()));
EmitLValue(E->getArg(E->getNumArgs() - 2)).getPointer(*this);
Value *Count2Addr =
EmitLValue(E->getArg(E->getNumArgs() - 2)).getPointer(*this);
Builder.CreateDefaultAlignedStore(Count1, Count1Addr);
Builder.CreateDefaultAlignedStore(Count2, Count2Addr);
}

Builder.CreateDefaultAlignedStore(Fifo, FifoAddr);
Builder.CreateDefaultAlignedStore(Avail, AvailAddr);
return Builder.CreateDefaultAlignedStore(Ptr, PtrAddr);
}
default:
break;
}
Expand Down Expand Up @@ -22513,7 +22651,18 @@ Value *CodeGenFunction::EmitAIE2PBuiltinExpr(unsigned BuiltinID,
case AIE::BI__builtin_aie2p_v64accfloat_to_v64bfp16ebs8:
case AIE::BI__builtin_aie2p_v64accfloat_to_v64bfp16ebs16:
case AIE::BI__builtin_aie2p_v64bfp16ebs8_to_v64bfp16ebs16:
case AIE::BI__builtin_aie2p_vshuffle_576_bfp16: {
case AIE::BI__builtin_aie2p_vshuffle_576_bfp16:
case AIE::BI__builtin_aie2p_fifo_st_push_576_bfp16:
case AIE::BI__builtin_aie2p_fifo_st_push_512_bfp16:
case AIE::BI__builtin_aie2p_fifo_st_push_544_bfp16:
case AIE::BI__builtin_aie2p_fifo_st_flush:
case AIE::BI__builtin_aie2p_fifo_st_flush_conv:
case AIE::BI__builtin_aie2p_fifo_st_flush_1d_byte:
case AIE::BI__builtin_aie2p_fifo_st_flush_conv_1d_byte:
case AIE::BI__builtin_aie2p_fifo_st_flush_2d_byte:
case AIE::BI__builtin_aie2p_fifo_st_flush_conv_2d_byte:
case AIE::BI__builtin_aie2p_fifo_st_flush_3d_byte:
case AIE::BI__builtin_aie2p_fifo_st_flush_conv_3d_byte: {
return this->EmitAIEBuiltinExpr(BuiltinID, E, Arch);
}
default:
Expand Down
Loading