[AIE2P] Refactor register bank selection #325
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niwinanto
force-pushed
the
niwin.regbank.select
branch
from
e68a4c6 to
3f14d94
Compare
andcarminati
reviewed
Feb 4, 2025
| }); | ||
| } | ||
|
|
||
| const RegisterBank *AIE2PRegisterBankInfo::getPreferredRegBankForVectorTy( |
There was a problem hiding this comment.
Could we have an optional getPreferredPartialMappingIdx(Type)? In this way we can merge a bunch of fifo acc code.
andcarminati
reviewed
Feb 4, 2025
| isAccRegMapping = true; | ||
| if (isUseFifoInsn(MRI, TRI, UseCandidate)) | ||
| if (&AIE2P::FifoRegBank == PreferredRB) |
There was a problem hiding this comment.
We the optional approach, we can simplify a lot this case.
niwinanto
force-pushed
the
niwin.regbank.select
branch
from
3f14d94 to
9ac5133
Compare
niwinanto
requested review from
abhinay-anubola,
abnikant,
F-Stuckmann,
gbossu,
katerynamuts,
khallouh,
konstantinschwarz,
martien-de-jong,
SagarMaheshwari99 and
stephenneuendorffer
as code owners
niwinanto
changed the title
khallouh
reviewed
Feb 5, 2025
| return hasFifoInput(UseMI, MRI, TRI, RegOp); | ||
| }); | ||
| // Trace Reg to its actual register, updating it if necessary | ||
| TraceToActualReg(Reg); |
There was a problem hiding this comment.
FYI: we currently don't have a test for this for the fifo bank because we weren't tracing the register. @andcarminati also implements it in #314 plus ignoring PHI nodes as well, so whichever PR go in first has to add the tests.
khallouh
reviewed
Feb 5, 2025
| }); | ||
| } | ||
|
|
||
| bool AIE2PRegisterBankInfo::isUsedAsFifoReg(const MachineRegisterInfo &MRI, |
There was a problem hiding this comment.
I got some suggestions regarding naming these functions after I had merged this #288 Can you check them and take them into account in this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.