Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge from fork origin develop #2

Merged
merged 20 commits into from
Aug 3, 2019
Merged

Conversation

XuYanci
Copy link
Owner

@XuYanci XuYanci commented Aug 3, 2019


CheckList

Thanks for considering to this repository. Before you submit your issue, please confirm these boxes are checked.

  • I have read 《[EN]Style guide for Flutter repo [CN]Flutter项目代码规范、规约选型》.
  • [EN]I have added screenshots for main devices if this PR includes UI updates. [CN]UI改动,需要将主要设备截图,表明本此 PR 的 UI 改动。
  • [CN]我遵守以下 Merge 规则:PR 提交后,邀请群组中任意一人进行 review,即可合并。让 reviewer 在 PR 所在页面写下 review 意见表示通过,即可合并。最简单写一句 LGTM 也可以。不按照本规则执行,自己 PR 自己 Merge 并引入问题,会被收回 Merge 权限。如无 merge 权限,请联系 @ChenYilong 执行 merge 操作。

screenshots

iPhoneX+ iPhone (except for iPhoneX+) android

My issue:

What I have done:

@XuYanci XuYanci merged commit 707bfad into XuYanci:develop Aug 3, 2019
@ChenYilong
Copy link

自己提pr,自己合并,不需要review吗?截图你截了吗?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants